Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp385990rwb; Fri, 4 Aug 2023 14:34:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpVLIVOPNFa1Zia+A1bnBfDWcAkxEbNNk5EIoqImLoda4OgiUoSvo9cfUm+YXWDWvA2BdN X-Received: by 2002:a17:902:ce8c:b0:1b9:e913:b585 with SMTP id f12-20020a170902ce8c00b001b9e913b585mr2519887plg.13.1691184854112; Fri, 04 Aug 2023 14:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691184854; cv=none; d=google.com; s=arc-20160816; b=cbhQDMWDUCN/Y7PckamjntOh+HpDylFOxSNo40vAaTZeZe9z3yuo5iPVGBCxY1iapf w1bWVh/5ODDq1dz1rYVi1xWe+uw5e0hPjwPkfkeaLNjkYL+6tqnvm0KuZtp3skats9NJ uLJtZAm9ucB7O62r6DCJkpd28rMF/SuQRDqZqw10ZxGCsuagJOKab9D/gznIISSaOVv0 sF8q8CuHq1l9e2R6lZAFIlfyLrG9+Huz+XdpXSKP4UuRPWxCkWsthVbXXY+1G+D27Fye h/OlXdi01xDi3RWS4X9UGhKf7R5vHZZoExLj9yGtWRv7OvS1x683UT8m1uHpR9s8RLxz uang== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Om8tETs8lwMRZ7xv5mcUWlXWg2s1vnhNISkDZ1OKiV4=; fh=w6FvAc7+08fEt8Fcv/nE3Q1zAko+2y4yhB8clnhGN4U=; b=oR85g/NCKmBvx4K9psrXvcO2vsoPyubeC3PX+u+lkG7VI6BxEjghYe2I9XAh3ZGrdw RWogfXNkak7K7mRXG49GZtAiV8v3s6FCiXVFsjYaGC7BzG1t5OuNL1EvM5h4JQd1flHG Ur4iaf65+CNQeSi865bD/27O5Q3nMRA8NnIS12mWjJJRq+9ef6h0l1UMBPFCwhmUDCKX aga4uw3RoWK0QtgCcbOVtyDkOCFHtkJ0Oq5Th1wMkFWkaecdouOG1d4aKsSI9PHl+yYf Hu4CH9ciP6rA/KmdkLvKnbA8UQULjNhUCiC1mpaW1C6n5XJoatkOBCoxUcMPyxtrZwmG uLIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D9tqZdJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a170902e80400b001bb8704e6f3si2416824plg.278.2023.08.04.14.34.02; Fri, 04 Aug 2023 14:34:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D9tqZdJ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbjHDUqg (ORCPT + 99 others); Fri, 4 Aug 2023 16:46:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjHDUqe (ORCPT ); Fri, 4 Aug 2023 16:46:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD98E4EC4 for ; Fri, 4 Aug 2023 13:46:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6128F61E90 for ; Fri, 4 Aug 2023 20:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50CB9C433C7; Fri, 4 Aug 2023 20:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691181989; bh=MeJG2vuAuzwQPAdsG0vf4tmGc9lh6I+FFfN9rIwpfm0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D9tqZdJ30TDBdZpjaI3uDUgJjJV4vCo9oKGYzNfnFLJ4X0rK27qJuVmgenqbdcJM1 OrqYnrLixy3ZCw2rcNFFVW20WKXlS5lWj7jUXR30VQjNFCPj+6JRBFwxYbmlRj4Q10 ZMZti95gpxwYsBAiur8KkXwn204nEJt8MEGjRCIyc3Y3xyrCxZg+CS3seOvZZAO7fI ORlnmyBbgYmEh37ie26N+8g4gj0Rk22K3x2ZMSNA25LrOo/AOzsPm+x5qO/Gnd+EAv RZ47rQLifPaoSV+YNoJLUfgA+e+Zf2jVPmmrUumq/iPh1XxvEIZy4R6MfClwVafHLM PfhGXK21lNmUg== Date: Fri, 4 Aug 2023 22:46:24 +0200 From: Simon Horman To: "huangjie.albert" Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Pavel Begunkov , Yunsheng Lin , Menglong Dong , Richard Gobert , "open list:NETWORKING DRIVERS" , open list , "open list:XDP (eXpress Data Path)" Subject: Re: [RFC Optimizing veth xsk performance 04/10] xsk: add xsk_tx_completed_addr function Message-ID: References: <20230803140441.53596-1-huangjie.albert@bytedance.com> <20230803140441.53596-5-huangjie.albert@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803140441.53596-5-huangjie.albert@bytedance.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2023 at 10:04:30PM +0800, huangjie.albert wrote: ... > index 13354a1e4280..a494d1dcb1c3 100644 > --- a/net/xdp/xsk_queue.h > +++ b/net/xdp/xsk_queue.h > @@ -428,6 +428,17 @@ static inline void __xskq_prod_submit(struct xsk_queue *q, u32 idx) > smp_store_release(&q->ring->producer, idx); /* B, matches C */ > } > > + nit: one blank line is enough > +static inline void xskq_prod_submit_addr(struct xsk_queue *q, u64 addr) > +{ > + struct xdp_umem_ring *ring = (struct xdp_umem_ring *)q->ring; > + u32 idx = q->ring->producer; > + > + ring->desc[idx++ & q->ring_mask] = addr; > + > + __xskq_prod_submit(q, idx); > +} > + > static inline void xskq_prod_submit(struct xsk_queue *q) > { > __xskq_prod_submit(q, q->cached_prod); > -- > 2.20.1 > >