Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 22:23:09 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ivan Mikhaylov <fr0st61te@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Po-Yu Chuang <ratbert@faraday-tech.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3] dt-bindings: net: ftgmac100: convert to yaml version
 from txt
Message-ID: <20230804-doorman-overdress-b1ea7393740e@spud>
References: <20230731074426.4653-1-fr0st61te@gmail.com>
 <20230804132034.4561f9d7@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="0xRaSzT8JWffNfAv"
Content-Disposition: inline
In-Reply-To: <20230804132034.4561f9d7@kernel.org>
Precedence: bulk


--0xRaSzT8JWffNfAv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 04, 2023 at 01:20:34PM -0700, Jakub Kicinski wrote:
> CC: Conor=20
>=20
> in case the missing CC is the reason for higher than usual=20
> review latency :)

You even CCed the +dt address so the mail ended up in the right place!
I doubt not having me on CC is the reason for the delay, seems to be a
pattern that the conversion patches end up being Rob's to look at. I at
least find them more difficult to review than new bindings.

It looks like Rob's comments on v(N-1) were resolved, but something here
looks odd to me.

> > +  clocks:
> > +    minItems: 1
> > +    items:
> > +      - description: MAC IP clock
> > +      - description: RMII RCLK gate for AST2500/2600
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +    contains:
> > +      enum:
> > +        - MACCLK
> > +        - RCLK

I don't really understand the pattern being used here.

> > -- clocks: In accordance with the generic clock bindings. Must describe=
 the MAC
> > -  IP clock, and optionally an RMII RCLK gate for the AST2500/AST2600. =
The
> > -  required MAC clock must be the first cell.

The order in the original binding was strict & the MAC clock had to come
first. What's in the new yaml one is more permissive & I think it should
be

  clock-names:
    minItems: 1
    items:
      - const: MACCLK
      - const: RCLK

unless of course I am missing something that is...

> > -- clock-names:
> > -
> > -      - "MACCLK": The MAC IP clock
> > -      - "RCLK": Clock gate for the RMII RCLK

--0xRaSzT8JWffNfAv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM1sPAAKCRB4tDGHoIJi
0rENAQD1vKcQgnhP6Ln+CWJv1wWzBmj3uPwvjHn2kG1gX4N5ngD+NbxpzHQUm8o2
ckkj4vJWvILJx7q/JO4+08b2JRrsUQo=
=DyLQ
-----END PGP SIGNATURE-----

--0xRaSzT8JWffNfAv--