Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 23:12:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marc Zyngier <maz@kernel.org>
Cc:     Johan Hovold <johan+linaro@kernel.org>,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1 1/1] irqdomain: Refactor error path in
 __irq_domain_alloc_fwnode()
Message-ID: <ZM1bm2+/lyb+IH86@smile.fi.intel.com>
References: <20230804164932.40582-1-andriy.shevchenko@linux.intel.com>
 <84f2ea9ee0c08c8826c0f26c4a6291c9@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84f2ea9ee0c08c8826c0f26c4a6291c9@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Aug 04, 2023 at 06:33:07PM +0100, Marc Zyngier wrote:
> On 2023-08-04 17:49, Andy Shevchenko wrote:
> > First of all, there is no need to call kasprintf() if the previous
> > allocation failed. Second, there is no need to call for kfree()
> > when we know that its parameter is NULL. Refactor the code accordingly.

...

> >  		n = kasprintf(GFP_KERNEL, "irqchip@%pa", pa);
> >  		break;
> >  	}
> > -
> > -	if (!fwid || !n) {
> > +	if (!n) {
> >  		kfree(fwid);
> > -		kfree(n);
> >  		return NULL;
> >  	}
> 
> What are you trying to fix?

I'm not trying to fix anything (there is no such statement from me),
but I would think of some micro-optimization (speedup boot for
unnoticeable time? Dunno.).

> We have a common error handling path, which makes it easy to
> track the memory management. I don't think this sort of bike
> shedding adds much to the maintainability of this code.

Your call, of course, but I not often see in the kernel two or three attempts
to allocate some memory and have grouped check for the failure.

> Now if you have spotted an actual bug, I'm all ears.

-- 
With Best Regards,
Andy Shevchenko