Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd80b41a26c62ba42efc51d9ab800bfb.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230728222639.110409-1-francesco@dolcini.it>
References: <20230728222639.110409-1-francesco@dolcini.it>
Subject: Re: [PATCH v1] clk: keystone: syscon-clk: Fix audio refclk
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
To:     Francesco Dolcini <francesco@dolcini.it>,
        Jai Luthra <j-luthra@ti.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Santosh Shilimkar <ssantosh@kernel.org>
Date:   Fri, 04 Aug 2023 18:12:57 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Francesco Dolcini (2023-07-28 15:26:39)
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>=20
> Audio REFCLK's are not working correctly, trying to use them lead to the
> following errors:
>=20
> [    6.575277] of_clk_hw_onecell_get: invalid index 4294934528
> [    6.581515] wm8904 1-001a: Failed to get MCLK
> [    6.586290] wm8904: probe of 1-001a failed with error -2
>=20
> The issue is that Audio REFCLK has #clock-cells =3D 0 [1], while the driv=
er
> is registering those clocks assuming they have one cells. Fix this by
> registering the clock with of_clk_hw_simple_get() when there is only one
> instance, e.g. "audio_refclk".
>=20
> [1] Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
>=20
> Fixes: 6acab96ee337 ("clk: keystone: syscon-clk: Add support for audio re=
fclk")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---

Applied to clk-fixes