Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp657749rwb; Fri, 4 Aug 2023 21:08:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+08em/wMYaINtowvnGVRxt5xnLId2WSkqgUyMCtMEMwor8wPK155n69baDvvxNtpAh4+t X-Received: by 2002:a17:906:108:b0:99c:570a:e23e with SMTP id 8-20020a170906010800b0099c570ae23emr3348682eje.24.1691208504795; Fri, 04 Aug 2023 21:08:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691208504; cv=none; d=google.com; s=arc-20160816; b=MraFPwBthTyDiuBcbS0CrXQ2uIedQis2eUfR82VUpifYhdwOf0chu//PChHkR/benj hAT3QposvajyZnS1lrAcfOJilZohZZc3uvL0lBXVqnVzmIFHNckVp7yqU1qAfAmWUOlX 1enBiIN+McMyjvXpZc1bHn3Adg2uPZn4fdfmY+A0cBw0h/sc3oe+hhv+R8LeVlCcMh6x kVnpFNKeCtaSeCM74DriiKEJAWsjQxmKlthhqRJCHBM/IBsJEmsoV2z4UBiHhC+v5dUL wXaggxu8nJKb8DwT/G7qtUIDXBg5LSkdzDe6IALV+GGHVbd0VaBDRUMIBzJj96JmPvR6 odeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QQeJoDQJDBrcmiDQoZDuhDVqS0ecwH5esaJOMFFNqmE=; fh=iMjFSzO3l9gXADssU1Q67/ONc9ruJ8Gn5fwooRpFPoU=; b=YTboRLzsnx6Kk+e2j+WD9ln33xAgkJ6kK5yDMLcVPZPIEn+nIR29tPwb2x+GrQA4dX mB+mnRxJrnqN6TAdQBU9b45d0XSbKCaBJVrhGLLgYa6nH6vldaL4ZzPk/TIymE2IosCv 6Mgj0KgVxWdsUnxpmOK7dOUwQNHx9MPO2xiem1FH3x7Rk0xlbbsF7uhov9Z4CMcIH6L+ fa2/dCZzO3NTXa6TEV/MF25CL8tNM/GJh7tDuRr2MgugD95zFofr95hBfFH3iErv/Goq S39KlNwT1BsQI/hmQY0DAX0fyUCdWpC5oNpKDUNIUmrQbLDvart4SZ8xlmGnCjZUTYtB hwlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WNGWCUei; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a17090625ce00b0099399ac6fdesi2625304ejb.79.2023.08.04.21.07.57; Fri, 04 Aug 2023 21:08:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WNGWCUei; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbjHEDg6 (ORCPT + 99 others); Fri, 4 Aug 2023 23:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjHEDg5 (ORCPT ); Fri, 4 Aug 2023 23:36:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 191414ED7; Fri, 4 Aug 2023 20:36:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7EC662181; Sat, 5 Aug 2023 03:36:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F714C433C8; Sat, 5 Aug 2023 03:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691206615; bh=Qy59dwEG2sEBKJ3uVrLEgSsdsjiZwNwzGCh/053dPdE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WNGWCUeixkpzWHdK9GIGvteKTCydmouSQP1Eb72m8cJgbMVe5WgQGc9DIziQsI+C1 PrtfH7DteoT0+nH/rzznc6aaigo776+iN+M7sBzMU+hKJV6GLkItmTkP5UJd2VKTcH Cukd/yuOLLluICossH7smU54svWy/5anSGCPXwWThtlKBaI8QSZeCBuQdUNEvIzl1b dxMspzfDw5A1lY26Ok9+ydjv9iU+0pS7z7RYGjcV2B64Y98xb1YjnUh5ZNU8M08s/E wfZDvXiLgtFojSxoXiOiPG2e3fogdAs9k7/SI7SSTw2y4pUA6/nP2MOqVRHyY08+q2 090W11bgrpMwA== Date: Fri, 4 Aug 2023 20:39:53 -0700 From: Bjorn Andersson To: Elliot Berman Cc: Alex Elder , Srinivas Kandagatla , Prakruthi Deepak Heragu , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Bagas Sanjaya , Will Deacon , Andy Gross , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 03/25] gunyah: Common types and error codes for Gunyah hypercalls Message-ID: References: <20230613172054.3959700-1-quic_eberman@quicinc.com> <20230613172054.3959700-4-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613172054.3959700-4-quic_eberman@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 10:20:31AM -0700, Elliot Berman wrote: > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h [..] > +/******************************************************************************/ > +/* Common arch-independent definitions for Gunyah hypercalls */ > +#define GH_CAPID_INVAL U64_MAX > +#define GH_VMID_ROOT_VM 0xff > + > +enum gh_error { "gh_" happens to be an unused prefix in the Linux kernel, but I find it to be an unnatural abbreviation of "gunyah". I would therefor prefer to have it expanded to "gunyah" for all functions, macros and data types throughout the implementation. Regards, Bjorn