Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp762690rwb; Sat, 5 Aug 2023 00:04:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFczZ+2J6w5F+XeTeN/Kaly1a0keNaUu7wjs9tXO/KB5wHCI8l4AeLsiUmj0tEEtgVdsNdz X-Received: by 2002:a05:6358:42a5:b0:137:82e6:166e with SMTP id s37-20020a05635842a500b0013782e6166emr4541264rwc.18.1691219061333; Sat, 05 Aug 2023 00:04:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691219061; cv=none; d=google.com; s=arc-20160816; b=kKXe236AcDv2JOh/J3CziA0fJOM6AgDPV+nuefNfMJrFO+3b9SbCVYp1K7qohEXlMQ leEYr6NBCCJkvplKBJdudydNCTgN9yeuvQztAiwTqd/nCWtX2zc6r4NAsWDxhx5LiBdr fMMWK6ag4U7rAapY9LNN2lvnySKtDlsj+srqXcK37DHlIRbokB6vC3o9QMnhEzax8FBY +eIvkH5YhWTaf037LiaBm2pY/BlnnLkMnXC2bfEaMre9p44RyHm6wH+A9YldlTzkjK14 dQYYhK5rBHp7CXSQ2QzQLdXRs732wOvPvLnHO83pm1YL4BE++CE586hcMAqz3MECCgi9 +7pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SHTNesW5Ypil+GWEzT7mhwXlIlksdFiRud+bW5Q5Piw=; fh=ZbBKr7TxtCJPyj9wvPRkQdT3H+SiZ+if93MPMB3nQD4=; b=lj21nEEUcSsmDdNQZwyh+yce7RhosEeZ0yJl3vc7nDUv+t8hJLshbTxzrysgZYSXqS uuxfywJMIcC7+5g3fMJvaioQnpeITBOINeBCWSH8Xah+FwmccZdkIkZB9FX77G5r0Q0M /P8Ry6mCabHbaDGxO/xgRyzKyolZEFtziqT4V3m9b/KWhNFe770UjovLoC1E4i23i8CU yhfKHskKHkG5/okqX+F3z8U0SCVl+3dChytjEk03JwSPvLf772jnMEmj88Zeq1uG5+rR h1lTn9l457E0/iGNHmjww0kirHX/2/jR0PPD0doLZzY3qIHFUSuhkAOVfl8i71aYrNUQ 8eJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=krCquNPU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 11-20020a63020b000000b00563d7685903si3001743pgc.703.2023.08.05.00.04.00; Sat, 05 Aug 2023 00:04:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=krCquNPU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbjHEGW1 (ORCPT + 99 others); Sat, 5 Aug 2023 02:22:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjHEGW0 (ORCPT ); Sat, 5 Aug 2023 02:22:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E7C4ED6; Fri, 4 Aug 2023 23:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12DD760AD6; Sat, 5 Aug 2023 06:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 165CEC433C8; Sat, 5 Aug 2023 06:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691216543; bh=71bkMSZKOc3HbinOnFH6CrCi9MNzOVOiV++TgrRs0RU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=krCquNPUKYxEdMuc6EYEPY8FF+8qdVLpNWeGVb7Bi4Lvanzga1ZgzDz72YEobrbwa liuvHaUB7WeuMZh01GdVUCh0ERZtx5s/3eemeuDuGdkY8XOl8D6uCxaLuSjVBpsZ3V bgyiYsgmXq2Nj4T1/pcvMARjJCAxLZMT2KMu2CMg= Date: Sat, 5 Aug 2023 08:22:20 +0200 From: Greg KH To: coolrrsh@gmail.com Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2] fixes warning Message-ID: <2023080507-umbrella-automated-0db9@gregkh> References: <20230804200711.65750-1-coolrrsh@gmail.com> <20230804200711.65750-2-coolrrsh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804200711.65750-2-coolrrsh@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2023 at 01:37:11AM +0530, coolrrsh@gmail.com wrote: > From: Rajeshwar R Shinde > > Typecasting the interrupt number from "unsigned int" to "signed int" to compare with 0(signed int by default). > Declaring interrupt number as "signed int" would violate kernel standards. So typecasting is the possible approach. > The fix is for spi-mpc52xx. > > This fixes warning such as: > drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING: Unsigned expression compared with zero: mps -> irq < 0 > > Signed-off-by: Rajeshwar R Shinde > --- > drivers/spi/spi-mpc52xx-psc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Your subject lines are still incorrect :(