Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   thunder.leizhen@huaweicloud.com
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Cc:     Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 0/2] kobject: Reasonably sanity check for kset->kobj.ktype
Date:   Sat,  5 Aug 2023 16:41:12 +0800
Message-Id: <20230805084114.1298-1-thunder.leizhen@huaweicloud.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Zhen Lei <thunder.leizhen@huawei.com>

Currently, there are four API paths for adding or registering kobjects:
1. Call kobject_init() first then kobject_add()
2. kobject_init_and_add()
3. kset_register()
4. kset_create_and_add()

Except for kset_register(), the other three paths ensure that kobj.ktype cannot be NULL.

According to the description in Documentation/core-api/kobject.rst:
 - A ktype is the type of object that embeds a kobject.  Every structure
   that embeds a kobject needs a corresponding ktype.

Add sanity check for kset->kobj.ktype in kset_register(), make sure that it cannot be NULL,
then all added or registered kobj/kset.obj, its ktype is not NULL. We can safely remove all
statements that check whether kobj.ktype is NULL. They're redundant.


Zhen Lei (2):
  kobject: Add sanity check for kset->kobj.ktype in kset_register()
  kobject: Remove redundant checks for whether ktype is NULL

 lib/kobject.c | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

-- 
2.34.1