Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 5 Aug 2023 11:17:21 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        Ramona Bolboaca <ramona.bolboaca@analog.com>,
        Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: mcp3911: add support for the whole
 MCP39xx family
Message-ID: <ZM4ToQ4EiuEwlbEi@gmail.com>
References: <20230804100248.3773861-1-marcus.folkesson@gmail.com>
 <20230804100248.3773861-2-marcus.folkesson@gmail.com>
 <ZM1Td+v3tcoaID9v@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="OZc4EUY9h3zGPqzZ"
Content-Disposition: inline
In-Reply-To: <ZM1Td+v3tcoaID9v@smile.fi.intel.com>
Precedence: bulk


--OZc4EUY9h3zGPqzZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Hi Andy,

Thanks for your revew!

[...]
>=20
> > +static int mcp3910_get_offset(struct mcp3911 *adc, int channel, int *v=
al)
> > +{
> > +	return mcp3911_read(adc, MCP3910_OFFCAL(channel), val, 3);
>=20
> Just to be sure, the proper endianess conversion is done in mcp3911_read()
> and mcp3911_write() calls?
>=20
> This question applies to all calls to that APIs.

Yes it does.

[...]

>=20
> > +static int mcp3910_get_osr(struct mcp3911 *adc, int *val)
> > +{
> > +	int ret =3D mcp3911_read(adc, MCP3910_REG_CONFIG0, val, 3);
>=20
> Have you run checkpatch? Here should be a blank line. Same in other sever=
al
> places.

Yes, checkpatch does not report any warning for this.

[...]

> > +	adc->chip =3D (struct mcp3911_chip_info *)spi_get_device_id(spi)->dri=
ver_data;
>=20
> Can't you use spi_get_device_match_data()?
>=20
> ...

Will go for spi_get_device_match_data().

[...]

>=20
> > +		device_property_read_u32(&adc->spi->dev, "device-addr", &adc->dev_ad=
dr);
>=20
> With
>=20
> 	struct device *dev =3D &adc->spi->dev;
>=20
> lines like this will be neater.

Indeed, but I think I will short it down to just spi->dev.

>=20
>=20
>=20

Best regards,
Marcus Folkesson

--OZc4EUY9h3zGPqzZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmTOE5wACgkQiIBOb1ld
UjKezw/9Ft3n9wG4UJox6bgPA6LdrFllY0Joyk8WcdHUzckCXh8R0kFowgIOhOOd
8LekC5lNQrx8r2aCpPwOyw7tuCVPjxrqUVxnF4ibU+HNFz4bqBodrXb6teUNAAHJ
8SBcgwfUsKz3zcg2WHKzcbZJYJnKHcdD5yzaecypRyNPFo+NfHhIoiav0tDWFMlk
6Ldd1Xa5w4xV4kCVt/BFl5YGOy/okrlntVEdWjL2+Jxu+rb7iD5FRQlS0d0OMPZk
WldHXAOpguEzJRMdRxPmWtEdhyfVyQEymSoKrS22iPJt/EJsxd+p3pvmq/PKdogD
4Q4dx4slUdYWD7CHRfTJ/cEMe3d9PUI5Cjqb381UavKJ4N/RsfgwoLO/LlbDZaBu
z6J9fTWKSFa0jPpXamxxaLeoTBTU8ZM0KHipK8xalaBO40NM7MsrIoWHSpBUYV6W
c4wDqpe5fz1YDOMZ+bea00Uyl+XlzNaVY/rWO2cflnRZ8I3550WaAKTPVJwlTy2F
58gwoEPD3X82RmTSAtwoVxTgXzbWileIM3/x0Hs08pksOuYUEkuFjCO1/i9sn2SB
JnCl6d3oRYW4D1+nksu5rFqPZIk72kIH4OgXdpG2x+gdRVt+iIBKWBKYUUhRJi3e
BF16knGzDggpv/+YYvGO3ZbjqfWSvf6tGyusiXOAGXw4Loz4Xgw=
=Rgh5
-----END PGP SIGNATURE-----

--OZc4EUY9h3zGPqzZ--