Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp910213rwb; Sat, 5 Aug 2023 03:49:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXM4gsuU4qyCnqjQMEucZX+Id3R/qIZH7+R0dPZlU+E6aUW0R4cb8ERmdRIkAfu8b2ITzQ X-Received: by 2002:aa7:d90d:0:b0:523:1ce9:1f49 with SMTP id a13-20020aa7d90d000000b005231ce91f49mr2954130edr.42.1691232568992; Sat, 05 Aug 2023 03:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691232568; cv=none; d=google.com; s=arc-20160816; b=KNg67hEvWa1biafP97mEisQVdikrRMK3jbcU/Iv9OpcBRTddtlBSvO/k7X0U2h2Ned meuJkb76Q4g86s37tZVZ2Jh+12OhtHatXuPOop0jWokt0cHyG3kUa1HHYHFxgMRIE5IA l8GYVgllSFJTVpaZ9y22/B/sA0qIbZ/fcU5jGPYA8BO3P2oSAxaGmhO4Zrt6AwlwFEv7 BUVB3Mfk6I6ZJnZo0Ci8IAlmrB+iIoFvAb/D9sUE/KdxCHwv1Z5i7/TQXfQSELn3wCPZ 4ch6D5893CszUSA4iAuGdHyrfdAHmGvT3yvgNntNmgPAgUnLmeFkrVoTwQ2sqdiVh8Ay XimQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=P6VZzB9tL0iN/0ZMqzLUDr4n20oYmvYRrHMv6FeuKsU=; fh=DLwOq0wZ9PvhkDiqIv6bT2B4PWCJgPIAUTgtqIWM33Q=; b=WUARfj1wDqTOFMdAhDiwBVQYtAu92GapUHGaWqhdgKGsm+jXy5ovYm+rxbdeElQhqz R0XEZbeQymdWpzUlZrokcSEJuZgbN2/g7NLcINRh/nw7XJE0+XZX04sXa+Ac6WbsqwM0 9Ld6Dz4V7feaeRjuuUkX7R/fxM9S7o6SmGKnPrzdm2OttSvs3SDSF7h8voPmeGtYE7zn 8UwW4SIxNjM8ouRwAoahLHbFUvhk+vNi6vUzmXaN+bJe2cwaEk8HnU3sM+SkpDG1iHjE xi7BQzoUAhqOtcLPJhlxv+15/+LwfTdVcRQwmggY0K1j9drkKJty2CQBVq7vRVo3X7hM dZyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iOy65PHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f5-20020a056402160500b005227e4f12fdsi2828816edv.237.2023.08.05.03.49.04; Sat, 05 Aug 2023 03:49:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iOy65PHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjHEJwK (ORCPT + 99 others); Sat, 5 Aug 2023 05:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjHEJwJ (ORCPT ); Sat, 5 Aug 2023 05:52:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A56C13A9B; Sat, 5 Aug 2023 02:52:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E37C60B2C; Sat, 5 Aug 2023 09:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 871EEC433C7; Sat, 5 Aug 2023 09:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691229123; bh=k1H8U6RI1llKdbpE02HLjjQniXPJI9WecDX0w+udZxg=; h=From:To:Cc:Subject:Date:From; b=iOy65PHDHA9Jq5LZS5cEJm54DND1H3goCPAPegqGgwjkecwpBBgT4HGFsJxMqneJl Bay944svlGQ3twdgUbs7nH1EdOLJvL97Uq9DRDK5bKFOen03SYiAHyzA9w9xDGp6zL f4K3ss+T77+WaCFWERfCteUAhVEZY2A9F/T3IpLRpBdwNF7iwScNdITpZfAo0Ymbu7 jaUQAFM0Pp8ziVCRJuOsJbErJmb1Od/zgljbzc/o6YVEK2D5SrlPQVIV/Z4olbJfFE PWY+GWRGLNyBOLYCoRhFADk7S2vSsOt38iQZEsJ7GSnFBbkJxOIHBhMDBvNuwchQGu SrU+Xkaxq+nkw== From: Arnd Bergmann To: Heikki Krogerus , Greg Kroah-Hartman , Rajat Khandelwal Cc: Arnd Bergmann , Neil Armstrong , Bjorn Andersson , Dmitry Baryshkov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: typec: intel_pmc_mux: select CONFIG_USB_COMMON Date: Sat, 5 Aug 2023 11:51:53 +0200 Message-Id: <20230805095157.3459892-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann It is possible to configure the typec drivers to be built-in while the actual USB host and device support is in loadable modules, but that now causes a link failure because the usb debugfs support is then not available to built-in code. x86_64-linux-ld: drivers/usb/typec/mux/intel_pmc_mux.o: in function `pmc_usb_init': intel_pmc_mux.c:(.init.text+0x3): undefined reference to `usb_debug_root' Select CONFIG_USB_COMMON to get it to build again, as we do for other drivers that require the core usb functionality. Fixes: 0a453dc9f2602 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs") Signed-off-by: Arnd Bergmann --- drivers/usb/typec/mux/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig index 784b9d8107e9b..65da61150ba78 100644 --- a/drivers/usb/typec/mux/Kconfig +++ b/drivers/usb/typec/mux/Kconfig @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC tristate "Intel PMC mux control" depends on ACPI depends on INTEL_SCU_IPC + select USB_COMMON select USB_ROLE_SWITCH help Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can -- 2.39.2