Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 5 Aug 2023 12:15:08 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Dhruva Gole <d-gole@ti.com>
CC:     Tony Lindgren <tony@atomide.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] pinctrl: single: Add compatible for ti,am625-padconf
Message-ID: <20230805171508.schg4xquoa24klk5@october>
References: <20230805045554.786092-1-d-gole@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230805045554.786092-1-d-gole@ti.com>
Precedence: bulk

On 10:25-20230805, Dhruva Gole wrote:
> From: Tony Lindgren <tony@atomide.com>
> 
> Add compatible for ti,am625-padconf to enable the use of wake-up events.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> 
> Base:
> *****
> tag: next-20230731 + below "depends on" patches
> 
> Depends on:
> ***********
> [0] Update pinctrl-single to use yaml
> [1] dt-binding: pinctrl-single: add am625 compatible
> 
> Links:
> ******
> [0] https://lore.kernel.org/linux-omap/20230731061908.GG5194@atomide.com/T/
> [1] https://lore.kernel.org/all/20230804050737.635186-1-d-gole@ti.com/
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> 
> Link to this patch:
> ******************
> https://lore.kernel.org/all/20230805045554.786092-1-d-gole@ti.com
> 
>  drivers/pinctrl/pinctrl-single.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index f056923ecc98..3a2a9910f2ec 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1954,6 +1954,12 @@ static const struct pcs_soc_data pinctrl_single_am437x = {
>  	.irq_status_mask = (1 << 30),   /* OMAP_WAKEUP_EVENT */
>  };
>  
> +static const struct pcs_soc_data pinctrl_single_am625 = {
> +	.flags = PCS_QUIRK_SHARED_IRQ | PCS_CONTEXT_LOSS_OFF,
> +	.irq_enable_mask = (1 << 29),   /* WKUP_EN */
> +	.irq_status_mask = (1 << 30),   /* WKUP_EVT */
> +};
> +

Why cant we set this in the k3-pinctrl.h and set it once?

The event will not be generated until wakeup daisy chain is triggered
anyways.

Have you looked at all the padconf registers across devices to ensure
the WKUP_EN/EVT bits are present? daisy chain feature is used elsewhere
as well.


>  static const struct pcs_soc_data pinctrl_single = {
>  };
>  
> @@ -1962,6 +1968,7 @@ static const struct pcs_soc_data pinconf_single = {
>  };
>  
>  static const struct of_device_id pcs_of_match[] = {
> +	{ .compatible = "ti,am625-padconf", .data = &pinctrl_single_am625 },
>  	{ .compatible = "ti,omap3-padconf", .data = &pinctrl_single_omap_wkup },
>  	{ .compatible = "ti,omap4-padconf", .data = &pinctrl_single_omap_wkup },
>  	{ .compatible = "ti,omap5-padconf", .data = &pinctrl_single_omap_wkup },
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D