Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1286750rwb; Sat, 5 Aug 2023 11:07:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaqhjvqGEtKETgtpc+ekX4s+HRHd0AJAAWyR9ImrsWhuBYHaCLHN7i+MRfo90G+Y5BtRNH X-Received: by 2002:a2e:9f16:0:b0:2b6:af60:6342 with SMTP id u22-20020a2e9f16000000b002b6af606342mr3401120ljk.40.1691258857917; Sat, 05 Aug 2023 11:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691258857; cv=none; d=google.com; s=arc-20160816; b=J7gm0Ji8hH3jDHkCAkbCnek7H9cifa4zbc1O4b3TBbg7j5fu2oqRwBs92/NCN3H9aN vktUWNVTvD/KCUwu6thUiSB296K1lQ+CqOKegq6CoX17lYuC4ZEBbLuJGkb9uYBu0NSo QabZapJFwRK3F0Ft8u6caxc5uoxxVEYtkTyex7Xp6keCEzI5cqPrztNe/UfSSrGsJV/D LoNG37BJg65Izc8NgWxQCtFaS9Yys6Z6uLZ82KSCMa2xke71G2eJl0W/gItBvGxFOa0n lAKf3h82el1HGOJ3CP2s7V53Zgmd0y0Wl8vy5sSSTZzcktbdIaCqTSyT3YeGN3mEJIU/ ssFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tJNvhG4lnJa+Dt0KKEblXW5gwUxVLeZOvps3NyUqChU=; fh=tkBhRJ2pcNLllQ9J5B+4Arr6Wk3XqCMpQbPpeZ6waNQ=; b=GdGVD7B5cYZa9Zsrpk1Crs1Y2XRNNpSOm48sPpWV4K6NeaFaiR9srP3NE12SUnzzW4 I/sK69Lab5G9g7YQdyOgxIvKtg7VrguDQdU3ZC7X+fNux9iM2tjr+pI1X1gj4FyF7iBl x4tZAlhkPAh+vnYJ6GKeBaruFzigSaGxgxf2KA7dLsM3BCvi67mi4J3QLNOCwjV2KvZE sPoNuipaV32etg/wiN1bR967tygtKWqjAjzD3nrmHo7MDn5Bz96nHN+qy6EKdErvzBYb XsWFElTlLhYqaV6hjv1muVyDnEVt+HU+u+1cWHDgpFvVSuFA0m3K7wErO0bKJM0SX3rU GXwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lbUO+5dN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a17090612c800b0098df1cbe2b1si3048264ejb.925.2023.08.05.11.07.13; Sat, 05 Aug 2023 11:07:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lbUO+5dN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbjHERSM (ORCPT + 99 others); Sat, 5 Aug 2023 13:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjHERSL (ORCPT ); Sat, 5 Aug 2023 13:18:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 004F7A2; Sat, 5 Aug 2023 10:18:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 87F3B60B58; Sat, 5 Aug 2023 17:18:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37CD0C433C8; Sat, 5 Aug 2023 17:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691255885; bh=OXwj6Cooj9Ihg/sm7mrynr9GEszBwcmewtrFn+JYvEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lbUO+5dNDie2ZigbafEP2076+UnaBSTN9incnnYL4IhzVZSIxrA3ojH4+NhfI7CD6 3mZjuYkMg3ZyQ/qwmlmWyuWDmlGH7iZQLo9mYl0b5GH3Ketu3lLLiHhEZZhLXTaGa3 zoYKc04FJ09rLJew451JxhKi0S2xe3aHnmLTva3hh6nGvYZ92MkEBqUOerzqA+vQxk 9iv67Ru+frwU2Gi2LhMTiQKqbYez9KP82GaEZeh2J9uPywvQUDOXsvESiF9+CbT4S9 93Va7WOZKOaPO0ZVyGxnzJGQHki6nrKVcWI5b9fVMhPfsOpFJYJabX4WsF7DZ/r/z1 hnzd2xjOpbLkg== From: Christian Brauner To: Aleksa Sarai Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexander Viro , Jens Axboe Subject: Re: [PATCH] open: make RESOLVE_CACHED correctly test for O_TMPFILE Date: Sat, 5 Aug 2023 19:17:54 +0200 Message-Id: <20230805-ignorant-kahlkopf-9749ac3cd20a@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230806-resolve_cached-o_tmpfile-v1-1-7ba16308465e@cyphar.com> References: <20230806-resolve_cached-o_tmpfile-v1-1-7ba16308465e@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1070; i=brauner@kernel.org; h=from:subject:message-id; bh=OXwj6Cooj9Ihg/sm7mrynr9GEszBwcmewtrFn+JYvEA=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSca7GXmqIzx996ktP0Gl3pK68nJvWG1K8J3XcrsP+22EbL 9h+GHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABM5sJORYar/Xgnn47aGRetCS/dzuH 1ZkXfl0sMXNhmKrbw11Yvm9TP8M64Ndv//1Nv36oE7U12FTE6f9beazfV46/kM1Uc3pbPTuAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 06 Aug 2023 02:11:58 +1000, Aleksa Sarai wrote: > O_TMPFILE is actually __O_TMPFILE|O_DIRECTORY. This means that the old > fast-path check for RESOLVE_CACHED would reject all users passing > O_DIRECTORY with -EAGAIN, when in fact the intended test was to check > for __O_TMPFILE. > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] open: make RESOLVE_CACHED correctly test for O_TMPFILE https://git.kernel.org/vfs/vfs/c/7c62794bc37f