Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zhangjin Wu <falcon@tinylab.org>
To:     tanyuan@tinylab.org
Cc:     falcon@tinylab.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, linux@weissschuh.net,
        tsbogend@alpha.franken.de, w@1wt.eu
Subject: [RFC 0/1] mips: malta: Select PCI_QUIRKS if POWER_RESET_PIIX4_POWEROFF is enabled
Date:   Sun,  6 Aug 2023 03:14:07 +0800
Message-Id: <20230805191407.45290-1-falcon@tinylab.org>
In-Reply-To: <686dbb3128ad4e413b22685cd466a68e1adf670b.1690968173.git.tanyuan@tinylab.org>
References: <686dbb3128ad4e413b22685cd466a68e1adf670b.1690968173.git.tanyuan@tinylab.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1
Precedence: bulk

Hi, Yuan

To even further reduce the time cost & waste of finding the exact
poweroff options for malta, I suggest to directly select the required
options when CONFIG_POWER_RESET=y:  

    config MIPS_MALTA
    	...
     	select MIPS_L1_CACHE_SHIFT_6
     	select MIPS_MSC
     	select PCI_GT64XXX_PCI0
    +	select PCI if POWER_RESET
    +	select PCI_QUIRKS if POWER_RESET
    +	select POWER_RESET_PIIX4_POWEROFF if POWER_RESET
     	select SMP_UP if SMP
     	select SWAP_IO_SPACE
     	select SYS_HAS_CPU_MIPS32_R1

But it looks a little ugly, let's think about how to improve it.

And aslo, due to the same reason, it is possible to send a RFC patchset
to select required poweroff options for CONFIG_POWER_RESET=y of the
other architectures, like the CONFIG_ACPI=y and CONFIG_PCI=y options for
i386/x86_64 and the CONFIG_MACINTOSH_DRIVERS=y and CONFIG_ADB_CUDA=y for
ppc g3beige.

To simplify the enablement of the poweroff support, selecting the required
options for CONFIG_POWER_RESET=y may make many people happy especially when
they are using a customized config (maybe tinyconfig based) for a target qemu
board. Without normal poweroff support from the kernel side, qemu will simply
hang there after a 'poweroff' command, which is a very bad experience for the
automatical tests. Currently, based on tinyconfig, it is very hard to find the
exact poweroff options, some architectures simply enable poweroff support by
default, the others' poweroff options are hidden deeply, which make things very
hard. 

Thanks,
Zhangjin

> Hi list,
> 
> I just found that the on QEMU Malta, POWER_RESET_PIIX4_POWEROFF relay on
> PCI_QUIRKS to work, or else the reboot will hang.
> 
> Welcome everyone's suggestions.
> 
> Yuan Tan (1):
>   mips: malta: select PCI_QUIRK for POWER_RESET_PIIX4_POWEROFF
> 
>  arch/mips/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> -- 
> 2.34.1