Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <822f63ef-d9e6-84f2-1a98-8a916ffaeb58@linaro.org>
Date:   Sat, 5 Aug 2023 23:27:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v5 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
Content-Language: en-US
To:     ChiYuan Huang <cy_huang@richtek.com>,
        Alina Yu <alina_yu@richtek.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <1690355592-10920-1-git-send-email-alina_yu@richtek.com>
 <1690355592-10920-2-git-send-email-alina_yu@richtek.com>
 <20230803063656.GA19124@linuxcarl2.richtek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230803063656.GA19124@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/08/2023 08:36, ChiYuan Huang wrote:
> On Wed, Jul 26, 2023 at 03:13:11PM +0800, Alina Yu wrote:
>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>>
>> Signed-off-by: Alina Yu <alina_yu@richtek.com>


>> +    
>> +  richtek,mtp-sel-high:
>> +    type: boolean
>> +    description:
>> +      vout register selection based on this boolean value.
>> +      false - Using DVS0 register setting to adjust vout
>> +      true - Using DVS1 register setting to adjust vout
>> +
>> +  regulators:
>> +    type: object
> Just curious.
> It seems this PMIC only support buck/ldo ouput.
> Since Krzysztof already reviewed it, not sure whether to group it into one node is common or not.
> AFAIK, if there's no more function included, to put all on the top level may be better.
>> +

Indeed we tend to avoid empty nodes just as a corresponding part to
Linux device.

Here, I don't know Rob's and Conor's opinion, but for cases of having
more than 2 regulators, having "regulators" node makes sense to me -
nicely organizes that piece of DT which can grow quite big. I can also
live without the "regulators" node.

Best regards,
Krzysztof