Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1468773rwb; Sat, 5 Aug 2023 16:31:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtJbErc3Ots42rmNKPPzrbsr1i8/gy6CxHAtE13Rrc09n0mEo2mPT72hqyVvzkhTXHH1dh X-Received: by 2002:a17:90a:2805:b0:268:6351:122 with SMTP id e5-20020a17090a280500b0026863510122mr3706483pjd.27.1691278294983; Sat, 05 Aug 2023 16:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691278294; cv=none; d=google.com; s=arc-20160816; b=ZcvKZ7/nM7WE2rZZ7f6LafL88V5aVzsHdGWAS3oVpOTWGVheQXELLUsZ53Zz3Xk8xE g8TXbjqEow6NRIui1kC+EsqfY4nSFy9Km2yK3NK3WwZN3CwXFuPYZISwlnY+tTaH+5Gi yxzpitkE93+slF5vR4RzvqJ1WySrldPJGvTWc53JjrzC0tUrA0GMbm/CSSfYBeNhvxqm OZG8GT+Lbq7Dbdv5wfCKRXPWZNqAT28MVg22EUmwvNWOlcdFEC/crsh6xfb8+PGaswtd I+JR0RuI5uDyolVPGv+kfZDv97fFe5vPgOsHJBqLvYGkfBF62D55LLLwnYpM9YY4Z+NX CNfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=wfoCc+RvjV+g+GLE3LFiITYI1ax4E6KyrUn9GtTQWKU=; fh=1CiMRn1dhwhwcyONGxBZ+OjqNLpRGO8YXNLfwfdfCtU=; b=qcv1g065RQa8puazMDAv7HfyY7YNu67CDYGbtVFil8QMR+dEPawGoa1KA6gGNlKVvB Sc9I2asYxhgBY8XInqzikJHj1ptvjAas/zyWr5gXxWT8jeCEOeNAAyGCBpID1NyOsxye JnREKpXyKgpanVQ5KywaYdeity5epoIkNjA0YiM4ES/foyLIxcsp5HdVdl3j7+/dz9uE kSExcxyrojXhXUUEAMpd2NcnWMC6N34pf6LQBlaHumhoua0LVy2TjfdJXqQcrlqO2zAd 4dGxSUChw5iWq/BdB+mJPdagb8LVFbD4w1DhDTyyLVBnk8x8LmpNLiub0li/KGYI7oqm FdtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=Y2h94Poj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a17090ad34600b00263ba5d7088si6825964pjx.48.2023.08.05.16.31.13; Sat, 05 Aug 2023 16:31:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=Y2h94Poj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229477AbjHEWNk (ORCPT + 99 others); Sat, 5 Aug 2023 18:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjHEWNj (ORCPT ); Sat, 5 Aug 2023 18:13:39 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C17FB10C9 for ; Sat, 5 Aug 2023 15:13:37 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b7dfb95761so5452825ad.1 for ; Sat, 05 Aug 2023 15:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1691273616; x=1691878416; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wfoCc+RvjV+g+GLE3LFiITYI1ax4E6KyrUn9GtTQWKU=; b=Y2h94PojIusanzrjPBql/8LV2CORjY1s6biXpvYlWwZA1L/KDwvg8dvBt37DG0mzpN B7dt7VojBlYTaPOWjlaP5esyiMkVGFyQucBOPNHcvfI5nN80tbVha52gvGMx6PAuPB0v I3ysUBajJcS2F0UybgEkEiBJjjMbxn/id96mFIOfl5hJoI7YRXvhcLxucQMIm0/wWZ4U 62tdfCNAIwzXEP8CaXC1q6uZg7CyC9VldzoAzQ5L2RoFlI9z8xHcM33mXz2xZvpT/pLI bMh/CR95r3UXAc39JwJxAjYlje52Q/t6RStTV8BsBBOms0Pux+zE5OS5TEZW6fN55YhK +zjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691273616; x=1691878416; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wfoCc+RvjV+g+GLE3LFiITYI1ax4E6KyrUn9GtTQWKU=; b=KtL91fWKsYl0n3b5zrR0W/GBNhBz1cUP2Cxx4BXS+oryAi3KRnLVdxxBHADOM6GgFv +sc6tNofpQnkmBmAUV3Av+/Ru/MozMIRPQoQJ0dsPX7ZObKla44OTNK7Cvmu0bNVENeX oV/wM8ldAWk7E950ArWZyg7xfA251okCQg9UqkM3Uxfh4yTFsm0OsMoUE63Fi1LA/cXT in/8MupeDs9Rg1oFWf9301Z2ZBSM2b1o9hwTAdJnoEYSkW4OLbvcJR5u5kcdnQTxB2XF GrDwUSwsZikF1B29km8r+5FELIdA1tgsWbV8J6s1gRsGM4H9paBLJ0T0ykfYUApna5Tk i90w== X-Gm-Message-State: ABy/qLZ3jJ7cS8E9YB3XRhG8/Vf+2+/VZIhBxv6/PInwQyxvRh5ENgdY Rz1sKlG4Gq1+McxfI2Kqbm5RaA== X-Received: by 2002:a17:902:d2d1:b0:1b8:ac61:ffcd with SMTP id n17-20020a170902d2d100b001b8ac61ffcdmr28867244plc.3.1691273616618; Sat, 05 Aug 2023 15:13:36 -0700 (PDT) Received: from [127.0.0.1] (071-095-160-189.biz.spectrum.com. [71.95.160.189]) by smtp.gmail.com with ESMTPSA id j21-20020a170902c3d500b001bba1188c8esm3929244plj.271.2023.08.05.15.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Aug 2023 15:13:35 -0700 (PDT) From: Jens Axboe To: minchan@kernel.org, senozhatsky@chromium.org, Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Dusty Mabe In-Reply-To: <20230805055537.147835-1-hch@lst.de> References: <20230805055537.147835-1-hch@lst.de> Subject: Re: [PATCH] zram: take device and not only bvec offset into account Message-Id: <169127361527.13732.4190461845439151626.b4-ty@kernel.dk> Date: Sat, 05 Aug 2023 16:13:35 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-034f2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 05 Aug 2023 07:55:37 +0200, Christoph Hellwig wrote: > Commit af8b04c63708 ("zram: simplify bvec iteration in > __zram_make_request") changed the bio iteration in zram to rely on the > implicit capping to page boundaries in bio_for_each_segment. But it > failed to care for the fact zram not only care about the page alignment > of the bio payload, but also the page alignment into the device. For > buffered I/O and swap those are the same, but for direct I/O or kernel > internal I/O like XFS log buffer writes they can differ. > > [...] Applied, thanks! [1/1] zram: take device and not only bvec offset into account commit: 95848dcb9d676738411a8ff70a9704039f1b3982 Best regards, -- Jens Axboe