Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <791fbf71-093e-3ef5-b02b-6d6bba72b57f@kernel.org>
Date:   Sun, 6 Aug 2023 10:05:53 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/1] f2fs: move fiemap to use iomap framework
Content-Language: en-US
To:     Wu Bo <bo.wu@vivo.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, wubo.oduw@gmail.com,
        Daeho Jeong <daehojeong@google.com>
References: <20230731012626.6843-1-bo.wu@vivo.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20230731012626.6843-1-bo.wu@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/31 9:26, Wu Bo wrote:
> This patch has been tested with xfstests by running 'kvm-xfstests -c
> f2fs -g auto' with and without this patch; no regressions were seen.
> 
> Some tests fail both before and after, and the test results are:
> f2fs/default: 683 tests, 9 failures, 226 skipped, 30297 seconds
>    Failures: generic/050 generic/064 generic/250 generic/252 generic/459
>        generic/506 generic/563 generic/634 generic/635

Can you please take a look at gerneic/473 ?

generic/473 1s ... - output mismatch (see /media/fstests/results//generic/473.out.bad)
     --- tests/generic/473.out	2022-11-10 08:42:19.231395230 +0000
     +++ /media/fstests/results//generic/473.out.bad	2023-08-04 02:02:01.000000000 +0000
     @@ -6,7 +6,7 @@
      1: [256..287]: hole
      Hole + Data
      0: [0..127]: hole
     -1: [128..255]: data
     +1: [128..135]: data
      Hole + Data + Hole
      0: [0..127]: hole
     ...
     (Run 'diff -u /media/fstests/tests/generic/473.out /media/fstests/results//generic/473.out.bad'  to see the entire diff)

Other concern is, it needs to test this implementation on compressed file,
since the logic is a little bit complicated.

+Cc Daeho Jeong

Thanks,