Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1595870rwb; Sat, 5 Aug 2023 20:47:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZiiX+IWyaA0/Xy4BTBRDjvMrCsTbPIGpLn1Hb7uXvjNVKT/iCBAE+djkfbAFXfYvNtiXA X-Received: by 2002:a17:906:83:b0:99c:5728:aeb6 with SMTP id 3-20020a170906008300b0099c5728aeb6mr5227166ejc.52.1691293630399; Sat, 05 Aug 2023 20:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691293630; cv=none; d=google.com; s=arc-20160816; b=BaD8uP49LTdTufo6hpOoipDSBcG622/nXDCxzVa9HO4Jr4iJYnX8tYN4kYO1EIgmxB CDGicN9FNd+nzW3Ig8wiPO1irVwB21pCn2Go02bMS7MT/LzYncpoZ7KmVTgdynj7EO2E kynFZ7bbnJtDC6rztqhoestXN9/Tm9RUa+5rUNSjZ7BOvMgQ8o1FRb0yuvS46V8xPAua Tgdoj3tKqA/mCQD7CHFK271Jgf74N/lpL14w2MwLuVKuVM/co60YZzQyP7iZIOZw4ccV tG1sr5uurMPrgfGQaP+EBH3tq5g6fdnOYq5eIM6Ic0AptwkT5OK05wRjjsQ2YHCwB/Oa arpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=xq6CasytF6DWCa+uN5IEl0sEQH3NZ6ieif6kVh8ZmkY=; fh=eXlaXhpMZbqdtwhjPi1zy2zOPzgU9AzpDGhFJ73lf4w=; b=CwRes1P2jR4nZbctGa4dE6lt5R/v6nQYyomzM3b4aLO97SW/7nuQUx9LmEkJyvQi6C inqzxF/b8XTiuox8i8JrdrTX0Ab1rsnOfZM0h6pvZYOjfNhes4A1LDCjJ+jATScOXBLJ N8aGiEEV7yw3pM6uQpjbEw7dV7l67dRsBk5CoZRpQkvrTmOMel9HqUi5dnE6zDf8bkok bW/Wd72l56MYNGSIbqgKoejzX61LMvtF6q1XdVcSN8o9/1csSfUC0idKaX96/q8JW8iW rYz3SzeyE27EMijx6KRim4ZBboKGY0jWOJ+1nYgivzKkISq/Ch1kEfYm6h0SerjXXVA2 CAUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jz11-20020a170906bb0b00b00992437c5881si3524340ejb.198.2023.08.05.20.46.45; Sat, 05 Aug 2023 20:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjHFCxK (ORCPT + 99 others); Sat, 5 Aug 2023 22:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjHFCxJ (ORCPT ); Sat, 5 Aug 2023 22:53:09 -0400 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911AE130 for ; Sat, 5 Aug 2023 19:53:04 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R781e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Vp4sLaG_1691290378; Received: from 30.121.9.24(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0Vp4sLaG_1691290378) by smtp.aliyun-inc.com; Sun, 06 Aug 2023 10:53:00 +0800 Message-ID: Date: Sun, 6 Aug 2023 10:52:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] watchdog/hardlockup: set watchdog_hardlockup_warned to true as early as possible To: Andrew Morton Cc: dianders@chromium.org, pmladek@suse.com, linux-kernel@vger.kernel.org References: <20230805160144.121875-1-liusong@linux.alibaba.com> <20230805101705.3a38ce9aacc924f1c9f0842b@linux-foundation.org> From: Liu Song In-Reply-To: <20230805101705.3a38ce9aacc924f1c9f0842b@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/6 01:17, Andrew Morton 写道: > When resending, please tell us some more about the effects of the > change. Presumably there are circumstances in which excess output is > produced? If so, describe these circumstances and the observed > effects. Hi, I haven't found duplicate warnings in the real environment. However, considering that when system occurs hard lockup is basically abnormal, it seems more reasonable to set "watchdog_hardlockup_warned" to ture, rather than waiting for all kinds of information to be printed. Thanks