Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230121175639.12818-1-linux.amoon@gmail.com> <20230121175639.12818-4-linux.amoon@gmail.com>
 <ZMrFb7H1ynwwBSCA@Dell-Inspiron-15> <45d25fd5-465f-347b-448b-ce171626f34e@linaro.org>
 <ZM7jtD2rniWAexVZ@Dell-Inspiron-15>
In-Reply-To: <ZM7jtD2rniWAexVZ@Dell-Inspiron-15>
From:   Anand Moon <linux.amoon@gmail.com>
Date:   Sun, 6 Aug 2023 09:33:14 +0530
Message-ID: <CANAwSgTBmLKknkWDUyZ2Byr15Oy6jbNxEYYjKGNr=2cOn5Wowg@mail.gmail.com>
Subject: Re: [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on
 odroid c2
To:     Ben Wolsieffer <benwolsieffer@gmail.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-amlogic@lists.infradead.org,
        Matthias Kaehlcke <mka@chromium.org>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Johan Hovold <johan@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ben,

On Sun, 6 Aug 2023 at 05:35, Ben Wolsieffer <benwolsieffer@gmail.com> wrote:
>
> On Sat, Aug 05, 2023 at 11:30:21PM +0200, Krzysztof Kozlowski wrote:
> > On 02/08/2023 23:06, Ben Wolsieffer wrote:
> > >
> > > Hello,
> > >
> > > This patch breaks USB support on the ODROID-C2. As soon as the
> > > onboard_usb_hub module is loaded, all USB devices disconnect.
> > > Blacklisting onboard_usb_hub makes USB work as expected.
> > >
> > > I tried to reproduce the problem by manually toggling the reset line,
> > > but the problem seems to be specific to this driver. When reset is
> > > asserted manually, the devices disconnect, but they all enumerate again
> > > as soon as reset is released.
> > >
> > > Also, I have been unable to make USB work again (until the next reboot)
> > > even after unloading onboard_usb_hub.
> >
> > Wasn't this patch made exactly to fix USB support, not break it? I might
> > be missing something but maybe this was not tested at all?
> >
> > Best regards,
> > Krzysztof
> >
>
> I have been using USB on the ODROID-C2 for several years without issues.
> It looks to me that this patch was designed to make reset control for
> the hub more elegant, rather than fix a specific issue. The same change
> was applied to several devices, so it seems plausible that it was not
> tested on all of them.
>

We tried to fix quite a few issues in the past but still, we could not
resolve core issues.
Will try to resolve these issues in the future.
I have tested these changes at my end on Odroid C1+, Odroid C2, and Odroid C4,

> Thanks, Ben

Thanks
-Anand