Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Aug 2023 16:42:37 +1000
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        Pavel Begunkov <asml.silence@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        io-uring@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] io_uring: correct check for O_TMPFILE
Message-ID: <20230806.063800-dusky.orc.woody.spectrum-98W6qtUkFLgk@cyphar.com>
References: <20230806-resolve_cached-o_tmpfile-v2-0-058bff24fb16@cyphar.com>
 <20230806-resolve_cached-o_tmpfile-v2-2-058bff24fb16@cyphar.com>
 <41b5f092-5422-e461-b9bf-3a5a04c0b9e2@kernel.dk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hguio7qt6czmuq3q"
Content-Disposition: inline
In-Reply-To: <41b5f092-5422-e461-b9bf-3a5a04c0b9e2@kernel.dk>
Precedence: bulk


--hguio7qt6czmuq3q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2023-08-05, Jens Axboe <axboe@kernel.dk> wrote:
> On 8/5/23 4:48?PM, Aleksa Sarai wrote:
> > O_TMPFILE is actually __O_TMPFILE|O_DIRECTORY. This means that the old
> > check for whether RESOLVE_CACHED can be used would incorrectly think
> > that O_DIRECTORY could not be used with RESOLVE_CACHED.
> >=20
> > Cc: stable@vger.kernel.org # v5.12+
> > Fixes: 3a81fd02045c ("io_uring: enable LOOKUP_CACHED path resolution fo=
r filename lookups")
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> > ---
> >  io_uring/openclose.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/io_uring/openclose.c b/io_uring/openclose.c
> > index 10ca57f5bd24..a029c230119f 100644
> > --- a/io_uring/openclose.c
> > +++ b/io_uring/openclose.c
> > @@ -35,9 +35,9 @@ static bool io_openat_force_async(struct io_open *ope=
n)
> >  {
> >  	/*
> >  	 * Don't bother trying for O_TRUNC, O_CREAT, or O_TMPFILE open,
> > -	 * it'll always -EAGAIN
> > +	 * it'll always -EAGAIN.
>=20
> Please don't make this change, it just detracts from the actual change.
> And if we are making changes in there, why not change O_TMPFILE as well
> since this is what the change is about?

Userspace can't pass just __O_TMPFILE, so to me "__O_TMPFILE open"
sounds strange. The intention is to detect open(O_TMPFILE), it just so
happens that the correct check is __O_TMPFILE.

But I can change it if you prefer.

--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--hguio7qt6czmuq3q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQS2TklVsp+j1GPyqQYol/rSt+lEbwUCZM9A3QAKCRAol/rSt+lE
b6q1AQCfpbiZQ3YBX5RjN7wlBlTKoVIIWmi3jbLZIfwsLpbALQEAxjj7JrE5m2QB
Ef3B/oTCkUaU5I9BTzF90EexiV0qAww=
=mPYA
-----END PGP SIGNATURE-----

--hguio7qt6czmuq3q--