Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1844588rwb; Sun, 6 Aug 2023 04:28:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+Zg6mC2sl5k+ECT1UvdFOdxqryG2Wq88Bf3mxQ/JRVmHgyUaqE/qOuPEca6yNyLHAvcBU X-Received: by 2002:a17:906:cc45:b0:96f:8666:5fc4 with SMTP id mm5-20020a170906cc4500b0096f86665fc4mr5564817ejb.50.1691321323425; Sun, 06 Aug 2023 04:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691321323; cv=none; d=google.com; s=arc-20160816; b=eTvq5eMr025UtP16ezvgfa3pMB0Iq2ijBL8SBfU2BfxPmCB78YiHWSxEhtav8NyoYo LumuJKYeIR/E2g3peQrzXBMSjvgLDUtFAwklQyFwwswse/lLZ1ML0DUEqPCB4v5IWH9U 3rQ1wuAUseQkgkpg421iD5IrendHCqjlAo65SAoIfuExQUUW9GPZ9RTY6RnuQIG8LxSu rgsMoZygV4B3Ejyqw6B0kSU28f6O1iyQ7tR757ZYbVPlNoM6o6c+ZW7If5pDe19P26sw NSN5Q+OOzN8ZohgWDzhBUntaL574x5oTCUVI7yT3t2u9EJ0/3WWvz775lGNO1LHlMJqV gDhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fydm/Tt/CmfvLXXBElsI19Cu+wmZuGi+PD4uO7dEV1o=; fh=OZZauf0oCkrDPZgcjxA9lqsIPDtkP2ElCYQv+pnQJPw=; b=KEpW8NFhCruMn3+bP5x7oVGZ+5OjzLwGxWU1MAjFQLlvUiykppNe2aOmSHJE/wWn+M IkNu4Lcrq+Se8oMUFupqmUxDu+xZCrli3ZYW79vJ6u6GcRvYjItw6Pg2MJLh42KFJ12o 5cRwmqk8EXj9jyc9j7Yuv1AnTGE7cJRYRnQUZkZPs3DRY/IBGxrd30sBHV1g2iwNgoV6 ogzwHBlUTiBmKzU6mwxR3k37+eQ4RtAM0KCnZq2w8JwJdLNSJCqPsnZmBx+70OTBeqE0 UYf1mBfHUP7AQpsaDO5II2hPF2jKni1LMYO3PzpmURKd6exNBUXQu/RfiQI/WXwsQ7zD uo2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="R/mNEtwL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020a170906d19000b0098dfb10f3a6si4194136ejz.107.2023.08.06.04.28.18; Sun, 06 Aug 2023 04:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="R/mNEtwL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbjHFK2H (ORCPT + 99 others); Sun, 6 Aug 2023 06:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbjHFK2F (ORCPT ); Sun, 6 Aug 2023 06:28:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA94D128; Sun, 6 Aug 2023 03:28:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 59AEB61015; Sun, 6 Aug 2023 10:28:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3AE6C433C7; Sun, 6 Aug 2023 10:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691317683; bh=HvLJ++4+vllHa04qfBVc6aFLPg2QE1A25oIoz1ifOtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/mNEtwLJQozWj7lttks60F4QC8ZMMAMXF++8wBpKcn28YasY6/QrZ9RshtO31jZf QnUnip3lJ9tgNpiS65Pk0+CeX61AxClmtY85zkc9J3pilo3AW9JmxJNvspeVhKVy4L TIVqzihHsf8CCA8nkgG9bapmxHicOz8c3J7XQCkAuos/tV2LsgH+JBmfc65V03LfEj t6UxIX25U7inBteX4vEPrK69N9M/LTI6ixGfLkMa2yqvc+jwLQrTO+6RYaBnBWFPIK CydrhvQtkK8fi5WCXWuWkQSo4zvhFJm3fbRyxeKADQIX6TKtF0Ne9DnwYMsSZdKzCX ZDjlNhn/AlEUw== Date: Sun, 6 Aug 2023 18:16:23 +0800 From: Jisheng Zhang To: Greg Kroah-Hartman Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Andy Shevchenko , Jiri Slaby , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] serial: 8250_dw: fall back to poll if there's no interrupt Message-ID: References: <20230806092056.2467-1-jszhang@kernel.org> <2023080643-chalice-exploring-e7ca@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2023080643-chalice-exploring-e7ca@gregkh> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 06, 2023 at 12:20:11PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 06, 2023 at 05:20:54PM +0800, Jisheng Zhang wrote: > > When there's no irq(this can be due to various reasons, for example, > > no irq from HW support, or we just want to use poll solution, and so > > on), falling back to poll is still better than no support at all. > > Ouch, really? Why not just fix the hardware instead? > Hi Greg, The HW may be designed as that to save interrupt lines if the uart is dedicated to debug purpose. I also see similar support in other uart drivers, for example liteuart.c, altera_uart.c, altera_jtaguart.c 8250_ioc3.c and so on. Thanks