Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Aug 2023 13:30:01 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Angel Iglesias <ang.iglesiasg@gmail.com>
Cc:     linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: pressure: bmp280: Use i2c_get_match_data
Message-ID: <20230806113001.26neek3slt3w77zt@pengutronix.de>
References: <cover.1691276610.git.ang.iglesiasg@gmail.com>
 <b3483bd87093d4cd0862904b70a167ebbb538644.1691276610.git.ang.iglesiasg@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bzetm4d6c34w7mbf"
Content-Disposition: inline
In-Reply-To: <b3483bd87093d4cd0862904b70a167ebbb538644.1691276610.git.ang.iglesiasg@gmail.com>
Precedence: bulk


--bzetm4d6c34w7mbf
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 06, 2023 at 01:15:03AM +0200, Angel Iglesias wrote:
> Replaces device_get_match_data() and fallback match_id logic by new
> unified helper function i2c_get_match_data().
>=20
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
>=20
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp=
280-i2c.c
> index 693eb1975fdc..4ebaa4edc4fc 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -11,9 +11,9 @@ static int bmp280_i2c_probe(struct i2c_client *client)
>  	const struct bmp280_chip_info *chip_info;
>  	struct regmap *regmap;
> =20
> -	chip_info =3D device_get_match_data(&client->dev);
> +	chip_info =3D i2c_get_match_data(client);
>  	if (!chip_info)
> -		chip_info =3D (const struct bmp280_chip_info *) id->driver_data;
> +		return -ENODEV;

the old code assumed that chip_info isn't NULL (implicitly by
dereferencing that pointer in the line below). I wouldn't change
semantics in a patch converting to a helper and so just do:

-	chip_info =3D device_get_match_data(&client->dev);
+	chip_info =3D i2c_get_match_data(client);
-	if (!chip_info)
-		chip_info =3D (const struct bmp280_chip_info *) id->driver_data;

or alternatively, if you think adding a check is a good idea, add an
error message in the error path and mention the semantic change in the
commit log.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--bzetm4d6c34w7mbf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmTPhDkACgkQj4D7WH0S
/k598gf/QYIEI5D+K8ylQZxk0SXcmUtPK1FbAhUY5CwUpmcE2tV0lG917a/XtYOI
+T2fLwtlZvVwQY2BiuObqtiqRZPNi3zHW1OsulMfKpD0MZLxtcZsVHlW3nTnEPYu
YKia11jR4Oj5TQbfzG8GSekIFZ4/5VqR+So+7DDaAWa+8c3RZ9o1oJU+Kqyu5H9d
huk7YtgDHdNu5FbgT3CbqFgECoq63cUYiQVcK4R0WRY8dOqRMAfDompSSx+eA8xb
oTOHltgJyHgC4cb/f0IHzR89ns8PuE0dRcPFE0NVKu7m7MSOUupHwu7bS0hLxPhL
ATrH21jzbIDuJoakCiEbEYbyFuQRxQ==
=R2Cx
-----END PGP SIGNATURE-----

--bzetm4d6c34w7mbf--