Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Akhil R <akhilrajeev@nvidia.com>
To:     Andi Shyti <andi.shyti@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>
CC:     "christian.koenig@amd.com" <christian.koenig@amd.com>,
        "digetx@gmail.com" <digetx@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
        "wsa@kernel.org" <wsa@kernel.org>
Subject: RE: [PATCH] i2c: tegra: Fix the check during DMA channel release
Thread-Topic: [PATCH] i2c: tegra: Fix the check during DMA channel release
Thread-Index: AQHZuME/tr0ShuZ0qUGsBKbHCTYYla++E/uAgB20fYCAAai1AA==
Date:   Sun, 6 Aug 2023 14:26:33 +0000
Message-ID: <DS7PR12MB633567393B1A709323983DADC00FA@DS7PR12MB6335.namprd12.prod.outlook.com>
References: <20230717151240.68899-1-akhilrajeev@nvidia.com>
 <ZLVdHzFm8yngLDj2@orome> <20230805130147.eabmdfbyttx2mjpl@intel.intel>
In-Reply-To: <20230805130147.eabmdfbyttx2mjpl@intel.intel>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yUSbxbhfX8hhd5d3LMw2F9b+pkGy97MTTmP1Jl6LJm62LifTZ5kKlzooVO3b?=
 =?us-ascii?Q?oZ+OilOkjhCRh5ECU726djXYZb7W27dq535Q28cmWtxgiW/3cfzuI5xFJ/sw?=
 =?us-ascii?Q?hI573PYHSUJeIdjOws02xRqE5apOrUCUecBWeuiBYfWHUoYm8u3AFfcmBZ/w?=
 =?us-ascii?Q?0xq9D+xIeT19IB2s2Dht6ozox1g9G2rC7ntfi5tICtjCLUuAQuq0xWkA6C2w?=
 =?us-ascii?Q?gXagS79bR1bs56kAu+iN0E7lqH+lDAtvOVwdN0OYS4MojwNVgQT+p7FLO1B6?=
 =?us-ascii?Q?x4kBASTLTwflpyiBKPw9JRAkpFxY2+X5pbHAWUnJjVINoXkHz1l7fYhUxfkw?=
 =?us-ascii?Q?WObECqyVgLni9JpjzybPAa5L24dxDOalVO5gpxyPCdv/dJQu/Z7U9RifiENC?=
 =?us-ascii?Q?XpE9/iqRvPRzRmUo+wsE/uAwMOeZHeArTV0PLS0L2CMj8c2CnqkZzo86rlbM?=
 =?us-ascii?Q?7mV2xIeIR4fFjAvdJrAYip/Ek3SDNGVQtZlWnN/URhgSE4dHQfrstSik2682?=
 =?us-ascii?Q?p6uwKStHAK21qu0eaq4/p0+cRW4O/tG1nUfEwh4fnSwwdB3vYreRe0crAkOy?=
 =?us-ascii?Q?iewHk63J6hUjr2Qvc0FPnfLSEzl0yggBc22oLSlT/GV2Mt4kl5IxX6yAwLop?=
 =?us-ascii?Q?Ane3q4fPP+X4VKswAaK3OeBpAkZUOb4AVfXx/QpfY4eaz2gKDEuD9HlzHHY6?=
 =?us-ascii?Q?Vc5jzxbRYMCQ41NqgiMLzvrkiksWfKrrYscNz6Y94Pk0lCyG6RArC08Fuusq?=
 =?us-ascii?Q?tR+gMjIoAFpkGL9C/SYAt+GU80sIno9yhgAZjvGo20IIJA4MObBT9h3wQHtW?=
 =?us-ascii?Q?GxJPl0T05Y4OLHLasi2PFilRQquv/FXjz9r1p8ErWRItHIZWRD1h/iYo3IhB?=
 =?us-ascii?Q?h2SvgwTN045AdHlDXhAYaCQAhqDh4ZX73oVI2Vj4/qocCf8Fzn5OVfK0+Mnr?=
 =?us-ascii?Q?AJRF9aQA+GIHMS5tIvFBMqApjHPI217t9U7hV8t95bPowcgMdUCutvZbuND4?=
 =?us-ascii?Q?jf1u6XCIhm0TelpXpUYGY2V1ujAK806UXKIjoBbRbcSAib2pBSH3bl6zudrF?=
 =?us-ascii?Q?018jQObnNp2R50XkRBgut+Rc3WNMXu4yagzoZnCJt5witJiwyi3hYyPlVNI0?=
 =?us-ascii?Q?yVXmP6KxwzS9N3MZMzRWA8QFSsk5COF2mFn/3quaTWO31P8+/e8QeZO9uf43?=
 =?us-ascii?Q?+0mdFGpm/fIiIp/CxBWyFh35Pc+dfOa4jRig6PJMZEZLNkvusn8Bj3kYDNly?=
 =?us-ascii?Q?t1VnmbZLdrZkVLt8p8wfuI3DutYwFl6eFFigoKcrn9zAxUF4mXovxW4gCB+5?=
 =?us-ascii?Q?uhOQZ/ItbC4qjRlVrbcwyV1pCG+5j5Tva3lW1evfmrztJM15GjOSmzsNwHiO?=
 =?us-ascii?Q?cOPmr9fsizORVUJvVzqCsaR1FjTPJdunqHY5Q0HrBVzWC9QeAWzNpcCQoriK?=
 =?us-ascii?Q?VDrZblN3ZwY4a6PlkuN8VDUZ6dvGdLHAsNCnJPmQQ+MGUPt8JGOupUmda6OE?=
 =?us-ascii?Q?Ro4U6jbKOiKiLW1MpBk8U1HSbVxRfU7IYEh5m8XZD9bsD1Hja+xHMZoAIUcJ?=
 =?us-ascii?Q?ZprVMjY/ET3ujX+XkSSX1BN7f/+OPl54SdmS3RfFfEF/Wu5FsPSeO9+lhaJU?=
 =?us-ascii?Q?PBFJeNbVv3YSHtcZMUVzVeC97wdz64hJfdHtB/e5rzV/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6335.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ce2b863-78b8-489a-ef7c-08db9689222d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2023 14:26:33.0733
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BVy68C2e+V248E1KEhgLrME12QUxA13PJRrasGWLkTb1crtmMBxX75ZgndI33Ndkzba3W2v3/BxXZTGvFMVjXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7551
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Hi Thierry and Akhil,
>=20
> On Mon, Jul 17, 2023 at 05:24:15PM +0200, Thierry Reding wrote:
> > On Mon, Jul 17, 2023 at 08:42:40PM +0530, Akhil R wrote:
> > > Check for error and NULL before attempting to release DMA channel.
> > >
> > > This, otherwise, was causing panic and crash in kernel when the
> > > dma_chan has an invalid value. The condition occurs during
> > > init_dma() when the dma_request_chan() function returns an error.
> > >
> > > Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and
> > > TX")
> > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > > ---
> > >  drivers/i2c/busses/i2c-tegra.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> I guess this patch is not needed anymore.
Correct. This can be discarded.

The below patch from Thierry is for the same fix.=20
https://lore.kernel.org/linux-i2c/20230707132619.2998382-1-thierry.reding@g=
mail.com/

Regards,
Akhil