Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Akhil R <akhilrajeev@nvidia.com>
To:     Andi Shyti <andi.shyti@kernel.org>,
        Parker Newman <pnewman@connecttech.com>
CC:     Laxman Dewangan <ldewangan@nvidia.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing
Thread-Topic: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing
Thread-Index: AQHZxx6LzpeyXcck3U+NjT3QFNG5jK/dQvCQ
Date:   Sun, 6 Aug 2023 14:21:49 +0000
Message-ID: <DS7PR12MB63358D8D877BBC81BF94C53AC00FA@DS7PR12MB6335.namprd12.prod.outlook.com>
References: <fcfcf9b3-c8c4-9b34-2ff8-cd60a3d490bd@connecttech.com>
 <20230804215631.wc22pkyetsyyt5ye@intel.intel>
In-Reply-To: <20230804215631.wc22pkyetsyyt5ye@intel.intel>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pEpv/22U6tPGt9jv/pz9da0yv0mEa/SBc3VakXxhaNkUDP2ZZWn3mCTFu+xj?=
 =?us-ascii?Q?p8B9GTs2BAK+eRb0gCb0GhaDDTFeXXbzAYWmyGFPq7TeoS1p95/Viz9DOrYb?=
 =?us-ascii?Q?fuQ01kMNo1NkrX8XUCUe6Jrmfiu9f2VdnKBgoooNaGXeTYaClyoIMIIga4Us?=
 =?us-ascii?Q?eqpAMBnZLUvTykPYaZx635X0AFon8onSm7INttKUhWbt9WCdNWhce8ssbAA8?=
 =?us-ascii?Q?en+uF6AKq6CyJVH/5ZKsawCl/f6oteIB3Tlq2pytmrsV8Nd8+Oz8ReCLJoFZ?=
 =?us-ascii?Q?vZOntLJi2lumjUhN247367NvihGXzn+dQAQ3pgAbb3DJ7kkIZdXrPO+bJS9D?=
 =?us-ascii?Q?yHjoDaYXc996kUs4ATqefectlCctal2zJ+WgwC2FkkoJO1Vk3E23h1MDi1bc?=
 =?us-ascii?Q?mSNgfOycJKCYtqu5TcxxfuMFzI3u8loBjP41RKE2h4kzXfyTgLgKoAU1xqUP?=
 =?us-ascii?Q?PpnuVKkXJDgvLxTDoGXuZX7cdFrbCQXDJFZNKQRkjHrd0s3qClydj5yCuzJM?=
 =?us-ascii?Q?Ps//ofstxgppqoPNNJq6pn+nYFKpgDKOCscqwxQndUs7WRgmyug8hyUBGrxm?=
 =?us-ascii?Q?sE/injmx2ZTM9mNJtPOjo553dilt5pDzpKu1XELcwcH3zyPYTX811f1YQlul?=
 =?us-ascii?Q?fN8mVZpMBSSd+C74pljboDXq59txjUlzEs85FFlytatkJGntdf+omwXusLqL?=
 =?us-ascii?Q?ed31q/PiB7ta9EaVyryCYMnJ7LGJ+TyKyIUdWo21zPCqWoczS2L2UJwsp3jq?=
 =?us-ascii?Q?pf+hYHcDqoE7RsSr/zqUk6SPIR8PJVyzImMdVEPCCmH1jSUKTXjUJ8UNeqyP?=
 =?us-ascii?Q?yQdOFe24ur0KCjYKagXyIxV8osMT8OxAvS64haawCWNxC6v6vAMPslyH35Ww?=
 =?us-ascii?Q?FRv/s7gSo1/itPztD3SDDIY5eMeAnpz/XIkJtdzL7UfXLKzZzcoFJ/ZMTaX6?=
 =?us-ascii?Q?gnJrFu+GkV2QFpKLe9JetjVf4B8+MVJfbIbbWKw/pieUyGXY5wT7mp1WpA/w?=
 =?us-ascii?Q?LQq6GkNCg7CHWDEhPSBrg7DTy1XqHayn5V5xAOlSIU/3w4blTsFUHmzuKYeG?=
 =?us-ascii?Q?k3P7yqYE/4ihWGuG580JbGTyjconesof4amPyaJg8TDH1pKJGDT1pEVSKoPf?=
 =?us-ascii?Q?K3j/oNhgs4XmhnEy3pQqUy22bp6u+GYCrzu3dWQef/Zlu3QH/FhvQgaq0n+B?=
 =?us-ascii?Q?WNtk6a/3RCEEa44yCiSnvkwH7UyxwGZqah87r9MPHXPul25pnSpOLWVZuKtm?=
 =?us-ascii?Q?oaQnKMPLk538goA4LcbS74pvR7ckHnvdVbYK4sj91h1p57ykxfl6236mk/V2?=
 =?us-ascii?Q?S3R7W38o/NXrL/Bb9Bk3YjWZuMXm1joqsXT2G8vpxOdeCeRw3XB20SQCzpPr?=
 =?us-ascii?Q?ZanV+fmTFjtgt8H0Scen8s0k2+v1WYJQ0y9VtYdNKu3XkjWm46YGfRLrCh80?=
 =?us-ascii?Q?kqJqJGGIicCC05W3NUEwNg+Sca5I+mLv/g32+UhtMLtiYk7pLWamWBnZJ7mi?=
 =?us-ascii?Q?4lQNlcImSqtmkdl8lmUIFPVwYIRX25ExZ4BuUZ4zRihxUPtgzUyIMVJ25/JB?=
 =?us-ascii?Q?Q3ki5faU33J4wTc+UtQZh3JikSl/4HEE2rJPxj5CDeFqJWTit5dmGmf7MVrN?=
 =?us-ascii?Q?H0NQoibtkB2jrTdSh2tVACJvmNKcdYYAO3KguJscI3L2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6335.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acdb719f-f41e-4799-7056-08db96887964
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2023 14:21:49.9135
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9lO9RjCrkB7F+yRpws/PlhDS5/2wxljWVVWcZ/NDdYL0YEi2P4CuBCVoHNRxn6x8bdcdCxkX1NGssiNj+JsdAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7551
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> BTW...
>=20
> On Thu, Aug 03, 2023 at 05:10:02PM +0000, Parker Newman wrote:
> >
>=20
> you have a blank line here.
>=20
> > This patch fixes the Tegra DMA config option processing in the
> > i2c-tegra driver.
> >
> > Tegra processors prior to Tegra186 used APB DMA for I2C requiring
> > CONFIG_TEGRA20_APB_DMA=3Dy while Tegra186 and later use GPC DMA
> > requiring CONFIG_TEGRA186_GPC_DMA=3Dy.
> >
> > The check for if the processor uses APB DMA is inverted and so the
> > wrong DMA config options are checked.
> >
> > This means if CONFIG_TEGRA20_APB_DMA=3Dy but
> CONFIG_TEGRA186_GPC_DMA=3Dn
> > with a Tegra186 or later processor the driver will incorrectly think
> > DMA is enabled and attempt to request DMA channels that will never be
> > availible, leaving the driver in a perpetual EPROBE_DEFER state.
> >
> > Signed-off-by: Parker Newman <pnewman@connecttech.com>
>=20
> As this is a fix you also need to add
>=20
> Fixes: 48cb6356fae1 ("i2c: tegra: Add GPCDMA support")
> Cc: Akhil R <akhilrajeev@nvidia.com>
> Cc: <stable@vger.kernel.org> # v6.1+
>=20
> Cc'eing Akhil as well for his opinion on this.
The fix looks valid to me. Must have been a typo there.

Regards,
Akhil