Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230806-pll-mipi_set_rate_parent-v5-0-db4f5ca33fc3@oltmanns.dev>
 <20230806-pll-mipi_set_rate_parent-v5-2-db4f5ca33fc3@oltmanns.dev>
 <3752134.kQq0lBPeGt@jernej-laptop>
From:   Frank Oltmanns <frank@oltmanns.dev>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@gmail.com>
Cc:     Maxime Ripard <mripard@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Roman Beranek <me@crly.cz>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 02/11] clk: sunxi-ng: nkm: consider alternative
 parent rates when determining rate
In-reply-to: <3752134.kQq0lBPeGt@jernej-laptop>
Date:   Sun, 06 Aug 2023 15:57:00 +0200
Message-ID: <87h6pc9sur.fsf@oltmanns.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 2023-08-06 at 15:32:29 +0200, Jernej =C5=A0krabec <jernej.skrabec@gmail.=
com> wrote:
> Dne nedelja, 06. avgust 2023 ob 15:06:47 CEST je Frank Oltmanns napisal(a=
):
>> In case the CLK_SET_RATE_PARENT flag is set, consider using a different
>> parent rate when determining a new rate.
>>
>> To find the best match for the requested rate, perform the following
>> steps for each NKM combination:
>>  - calculate the optimal parent rate,
>>  - find the best parent rate that the parent clock actually supports
>>  - use that parent rate to calculate the effective rate.
>>
>> In case the clk does not support setting the parent rate, use the same
>> algorithm as before.
>>
>> Acked-by: Maxime Ripard <mripard@kernel.org>
>> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>
>> ---
>>  drivers/clk/sunxi-ng/ccu_nkm.c | 45
>> +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 44
>> insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_n=
km.c
>> index f267142e58b3..ea1b77e9b57f 100644
>> --- a/drivers/clk/sunxi-ng/ccu_nkm.c
>> +++ b/drivers/clk/sunxi-ng/ccu_nkm.c
>> @@ -6,6 +6,7 @@
>>
>>  #include <linux/clk-provider.h>
>>  #include <linux/io.h>
>> +#include <linux/math.h>
>
> Why do you need above include?

It's not needed. It's a leftover from an earlier version. I'll remove it
in v6.

Thank you for your review,
  Frank

>
> Best regards,
> Jernej
>
>>
>>  #include "ccu_gate.h"
>>  #include "ccu_nkm.h"
>> @@ -16,6 +17,45 @@ struct _ccu_nkm {
>>  	unsigned long	m, min_m, max_m;
>>  };
>>
>> +static unsigned long ccu_nkm_find_best_with_parent_adj(struct clk_hw
>> *parent_hw, +
>        unsigned long *parent, unsigned long rate,
>> +
> struct _ccu_nkm *nkm)
>> +{
>> +	unsigned long best_rate =3D 0, best_parent_rate =3D *parent, tmp_parent
> =3D
>> *parent; +	unsigned long best_n =3D 0, best_k =3D 0, best_m =3D 0;
>> +	unsigned long _n, _k, _m;
>> +
>> +	for (_k =3D nkm->min_k; _k <=3D nkm->max_k; _k++) {
>> +		for (_n =3D nkm->min_n; _n <=3D nkm->max_n; _n++) {
>> +			for (_m =3D nkm->min_m; _m <=3D nkm->max_m; _m++)
> {
>> +				unsigned long tmp_rate;
>> +
>> +				tmp_parent =3D
> clk_hw_round_rate(parent_hw, rate * _m / (_n * _k));
>> +
>> +				tmp_rate =3D tmp_parent * _n * _k /
> _m;
>> +				if (tmp_rate > rate)
>> +					continue;
>> +
>> +				if ((rate - tmp_rate) < (rate -
> best_rate)) {
>> +					best_rate =3D tmp_rate;
>> +					best_parent_rate =3D
> tmp_parent;
>> +					best_n =3D _n;
>> +					best_k =3D _k;
>> +					best_m =3D _m;
>> +				}
>> +			}
>> +		}
>> +	}
>> +
>> +	nkm->n =3D best_n;
>> +	nkm->k =3D best_k;
>> +	nkm->m =3D best_m;
>> +
>> +	*parent =3D best_parent_rate;
>> +
>> +	return best_rate;
>> +}
>> +
>>  static unsigned long ccu_nkm_find_best(unsigned long parent, unsigned l=
ong
>> rate, struct _ccu_nkm *nkm)
>>  {
>> @@ -124,7 +164,10 @@ static unsigned long ccu_nkm_round_rate(struct
>> ccu_mux_internal *mux, if (nkm->common.features &
>> CCU_FEATURE_FIXED_POSTDIV)
>>  		rate *=3D nkm->fixed_post_div;
>>
>> -	rate =3D ccu_nkm_find_best(*parent_rate, rate, &_nkm);
>> +	if (!clk_hw_can_set_rate_parent(&nkm->common.hw))
>> +		rate =3D ccu_nkm_find_best(*parent_rate, rate, &_nkm);
>> +	else
>> +		rate =3D ccu_nkm_find_best_with_parent_adj(parent_hw,
> parent_rate, rate,
>> &_nkm);
>>
>>  	if (nkm->common.features & CCU_FEATURE_FIXED_POSTDIV)
>>  		rate /=3D nkm->fixed_post_div;