Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sathesh B Edara <sedara@marvell.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Satananda Burla <sburla@marvell.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>
Subject: Re: [net-next PATCH] octeon_ep: Add control plane host and firmware
 versions.
Thread-Topic: [net-next PATCH] octeon_ep: Add control plane host and firmware
 versions.
Thread-Index: AQHZyIahtdrq2jlOqEW3B0E+7cunMg==
Date:   Sun, 6 Aug 2023 16:54:14 +0000
Message-ID: <BN6PR1801MB1971FE9234B6EE4CF56555E4D80FA@BN6PR1801MB1971.namprd18.prod.outlook.com>
References: <20230629084227.98848-1-sedara@marvell.com>
 <9c470add-1a35-4f09-bba6-12b99f890a82@lunn.ch>
In-Reply-To: <9c470add-1a35-4f09-bba6-12b99f890a82@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2n6WHlIVdTeelsevRodoJwJVjfaAVY3V9aDOKaQN+Hj8XH2NOB9PBzWQk0il?=
 =?us-ascii?Q?ay+1CwA0FpCHkllWqcCfyKbVqBkpPFPqKkjHM88/j9hE+RxuBD8sv9aaoUJt?=
 =?us-ascii?Q?a6Bjr5CGU1V8vXUY+AFZoX1xXvlXoIFcXeaYTnawXicFOvMD8iFjDQ0nZ7+5?=
 =?us-ascii?Q?V6gdySDdcIotEkIjg4CERE4MiY5sU8tuioZx499fJBJqXvzzA3AjnxXDxYBb?=
 =?us-ascii?Q?8zgWcco+EsghaqRgKpU1tNxMi1sRtus8w6/iO8zQtwuPfIHUsqFDAx/hdNb9?=
 =?us-ascii?Q?yRzUrDMGZABeW6/ylvOSvMq3kLHzJga3v3rp+I9GLVEhcCfk+aCY+JONlIkK?=
 =?us-ascii?Q?Z2EEN4WPGOZFHub32HnCR0ewqbf8C2OGCG0BIM+AQd1vzXQL5TUNr7VVpHxf?=
 =?us-ascii?Q?e9hkohyZzkFjio+cSZQ3WwNi0gPgesJROh1zQdPgDncLYbXw1lA1XW6xEC5N?=
 =?us-ascii?Q?bpNmmRJnn4ICRRajDS0fxB3HR6tHF7E8Illr16MZBB+oTZpFW6VGOfbuvII7?=
 =?us-ascii?Q?0jDbI57VyUlS0ETluwnOR4g1r6zGUsYKkcomiUbuZ21H5/zYfxhEF9zwbhLC?=
 =?us-ascii?Q?u8YApjtxmWruWtlxzaERxGh0iC/mfs6e0XzSz5l++tlujXJGLH9FqS/upvSs?=
 =?us-ascii?Q?Cr7/GaJsJUgFV2zIg/ILfMnI2Xf6BePT1WpPqrNDvmr9txHZvjKQf0GcZzmk?=
 =?us-ascii?Q?OVpFbiOZd+iJKg16Lm4JluaaHoGq0R2c8euqjotDQEnfJ4DylfqZ43bLcPQl?=
 =?us-ascii?Q?CNI227vfDS0ab1O8kIcYt6xSltrW825FTmvEbAnPAg2Vi9ZyH3ijOGfIOHLo?=
 =?us-ascii?Q?aJ7cWeg6nO4S1JDhcXA3KLx9okttgX0Kd8yD7Wwn0Ouqn5aQb36/rB+C1/7j?=
 =?us-ascii?Q?ultZWamfuPtpqejqNV0I3Lr3hK9h/KSA6f4Gx++JniYijvW9CPeAg1pD6jGZ?=
 =?us-ascii?Q?cmz5hN1MEroq+eu7Rll6UmjZfr5tUvkpo6S1g+6wCLq4f/rHD+UxW81JjXsL?=
 =?us-ascii?Q?y7HgBmnGirD6rHHIcKKuP76oTEfnh71KPICPWI+8M32HG9Nn4+HaAfndbjAm?=
 =?us-ascii?Q?UVl8VSYcjWh3V3EnwwWBOorqzkZoTosSlPbmwuZnlamWoQNt1f6G05drTIV0?=
 =?us-ascii?Q?4LVZ7dzV1cI0/Fwe186PYxDvaMpaUeS6TeX0PBk0UAIOBmGCwO9h5DctQRUH?=
 =?us-ascii?Q?v1QsYEAMuRMlgkzVy1X4E6Kycl/7mRMl/PgzbMWRUTZQiWvuvWC63LSML1Q9?=
 =?us-ascii?Q?to0OmMp9EkVlFPB/vYF0XonE/MmqE+HKizJKuZZdEKcnWtDXUmKOJCbhLIhO?=
 =?us-ascii?Q?Qro95FceeaCsT6ROsWOgxqirmj6/EWB1upaThovye/Np5iH4le8dKTD+YSSJ?=
 =?us-ascii?Q?VFY25Tb2lsLqr6UOkKB5vuCTu1HGPbzuiJUguzwc1GRG1eekCs7V6tsz1pfb?=
 =?us-ascii?Q?9DSoclWBj7RdiAN8ceyR65FJBKDSMcafakduIKa1RZnmMofUo7CypeIB0nzM?=
 =?us-ascii?Q?u+e4rcW6B2rjEjImCKbCOpXBVwDc0XOupNoWpPKSnS7kUZm1qY10dx6Y3r2c?=
 =?us-ascii?Q?zUZwS8eUL7eLG7b5VeU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1801MB1971.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7852c6a-1e47-4bd3-0fa6-08db969dc445
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2023 16:54:14.9616
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jeg/dbaz2LoIshbA3s+4Raayca79P8XExE640D5NV6/2fUo4cha1dOabOiQ8CSR+3NBXTAT0IeUgVRpvR0qoYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3799
X-Proofpoint-GUID: Jx3iSalcn7bzVsW7zRKV0h8stb2CsAD9
X-Proofpoint-ORIG-GUID: Jx3iSalcn7bzVsW7zRKV0h8stb2CsAD9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-06_14,2023-08-03_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,
 Apologies for late response.

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>=20
Sent: Thursday, June 29, 2023 7:10 PM
To: Sathesh B Edara <sedara@marvell.com>
Cc: linux-kernel@vger.kernel.org; Satananda Burla <sburla@marvell.com>; Vee=
rasenareddy Burru <vburru@marvell.com>; davem@davemloft.net; edumazet@googl=
e.com; kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; Haseeb G=
ani <hgani@marvell.com>
Subject:  Re: [net-next PATCH] octeon_ep: Add control plane host and firmwa=
re versions.

>  int octep_ctrl_net_init(struct octep_device *oct)  {
>  	struct octep_ctrl_mbox *ctrl_mbox;
> @@ -84,12 +101,22 @@ int octep_ctrl_net_init(struct octep_device *oct)
> =20
>  	/* Initialize control mbox */
>  	ctrl_mbox =3D &oct->ctrl_mbox;
> +	ctrl_mbox->version =3D OCTEP_CP_VERSION_CURRENT;
>  	ctrl_mbox->barmem =3D CFG_GET_CTRL_MBOX_MEM_ADDR(oct->conf);
>  	ret =3D octep_ctrl_mbox_init(ctrl_mbox);
>  	if (ret) {
>  		dev_err(&pdev->dev, "Failed to initialize control mbox\n");
>  		return ret;
>  	}
> +	dev_info(&pdev->dev, "Control plane versions host: %llx, firmware: %x:%=
x\n",
> +		 ctrl_mbox->version, ctrl_mbox->min_fw_version,
> +		 ctrl_mbox->max_fw_version);

> Please consider exporting this information via devlink.

Sure I agree. This will be implemented as separate patch.

> +	ret =3D validate_fw_version(ctrl_mbox);
> +	if (ret < 0) {
> +		dev_err(&pdev->dev, "Control plane version mismatch\n");
> +		octep_ctrl_mbox_uninit(ctrl_mbox);
> +		return -EINVAL;
> +	}

> If i'm reading this correct, a mismatch is fatal, the driver probe will e=
rror out. That sort of thing is generally not liked. The driver worked so f=
ar with mismatched firmware. It should keep working, but not offer the feat=
ures which require matching firmware.

Yes. You are correct this check is not required and I will submit the V2 pa=
tch by excluding this firmware version check.=20

 >  Andrew
Thanks,
Sathesh