Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Aug 2023 21:51:28 +0200
From:   Simon Horman <horms@kernel.org>
To:     Simon Horman <horms@kernel.org>
Cc:     yang.yang29@zte.com.cn, jmaloy@redhat.com, davem@davemloft.net,
        ying.xue@windriver.com, edumazet@google.com, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tipc: add net device refcount tracker for bearer
Message-ID: <ZM/5wD5hZqgDNg3i@vergenet.net>
References: <202308041653414100323@zte.com.cn>
 <ZM4yAOKtdcTBXQQY@vergenet.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZM4yAOKtdcTBXQQY@vergenet.net>
Precedence: bulk

On Sat, Aug 05, 2023 at 01:26:56PM +0200, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 04:53:41PM +0800, yang.yang29@zte.com.cn wrote:
> > From: xu xin <xu.xin16@zte.com.cn>
> > 
> > Add net device refcount tracker to the struct tipc_bearer.
> > 
> > Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> > Reviewed-by: Yang Yang <yang.yang.29@zte.com.cn>
> > Cc: Kuang Mingfu <kuang.mingfu@zte.com.cn>
> 
> ...
> 
> > @@ -479,7 +479,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b)
> >  	dev_remove_pack(&b->pt);
> >  	RCU_INIT_POINTER(dev->tipc_ptr, NULL);
> >  	synchronize_net();
> > -	dev_put(dev);
> > +	netdev_put(dev, &b->devtracker);
> >  }
> > 
> >  /**
> > diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
> > index 41eac1ee0c09..1adeaf94aa62 100644
> > --- a/net/tipc/bearer.h
> > +++ b/net/tipc/bearer.h
> > @@ -174,6 +174,7 @@ struct tipc_bearer {
> >  	u16 encap_hlen;
> >  	unsigned long up;
> >  	refcount_t refcnt;
> > +	netdevice_tracker	devtracker;
> 
> Hi Xu Xin and Yang Yang,
> 
> Please add netdevice_tracker to the kernel doc for struct tipc_bearer,
> which appears just above the definition of the structure.
> 
> >  };
> > 
> >  struct tipc_bearer_names {
> 
> With that fixed, feel free to add:
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Given review of other, similar patches, by Eric.
I think it would be best to confirm that this patch
has been tested.