Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Robin Gong <yibin.gong@nxp.com>
Subject: RE: [PATCH V5 6/9] firmware: imx: scu-irq: fix RCU complains after M4
 partition reset
Thread-Topic: [PATCH V5 6/9] firmware: imx: scu-irq: fix RCU complains after
 M4 partition reset
Thread-Index: AQHZw41xv1ojgpBuAUSkGn78CZgks6/eMxOAgAADviA=
Date:   Mon, 7 Aug 2023 03:28:06 +0000
Message-ID: <DU0PR04MB94177737DACD5C77C55E3129880CA@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230731090449.2845997-1-peng.fan@oss.nxp.com>
 <20230731090449.2845997-7-peng.fan@oss.nxp.com>
 <20230807031309.GO151430@dragon>
In-Reply-To: <20230807031309.GO151430@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4KwbJXxE/48QvNQGlJnwH/GsdWArxOlYu36QAxrHOeh6nOxvOlDRzo5b03Tr?=
 =?us-ascii?Q?UD3KKpzgFenG1pZSeMO52peSvlE7VuhdN0clL88AEey9rdEqZwrmQ5Jw+z9M?=
 =?us-ascii?Q?4eWjby3uWBEbgDuJkU+ctx0Whiad8Pbm92paw+t90kN5xI+4o7euxzL2rTi0?=
 =?us-ascii?Q?sdHzujdLZMVsKKDcGGeCurqM7udQeHtAczBPCenMjgdmmm9GnWcXko6PLGkH?=
 =?us-ascii?Q?y87hnLaw/eZl3EUih71T/OgVbJKqhwAYAp39Mt9BmQn2k4i5EIdryZcmTU8k?=
 =?us-ascii?Q?4gj9i5gvDBzMHLJpQIarVcU6d67EUIOEh05pUXCV74Tkr8L5EqEH+BR+lwaD?=
 =?us-ascii?Q?iV7T9Zp5Gz2hFs70fUykflAxeDOOWPEy3rZR/UcMvgxXgoah/Pk3r4S0D+oF?=
 =?us-ascii?Q?+BUmaImeyIZMczkiUDk+Zmcf6edTLQ/plV2X9WJmLdBGNh856Xu3fL3OgY44?=
 =?us-ascii?Q?E033boe3M+bu7wqKiPcpH1acozIOsqGIGraHw1vuitBPukTTBctUzlhwaO8z?=
 =?us-ascii?Q?aRThXvAOxCL/QygT5Fl4LcHp7FlO43e2IRkpPR9c8waud0XbulUKAYqAjdCm?=
 =?us-ascii?Q?7reqa/e+L8dK9Y1P7nX/FeTteyKDpEy4yIuP37o4U4eunYDRWjLKfzY6U4FN?=
 =?us-ascii?Q?RrkwmNEFY7hsfM67L2BIvY2fN22KG3GnCsUXUukM0Fs8KV/wKUHYBP0MNEsJ?=
 =?us-ascii?Q?g2u5wVJefG+IikJf8y8IpMiIhyZwGiQ/2qUQQ6K7qkspBK5dTZ0Hwd6grwbQ?=
 =?us-ascii?Q?EtzdB0ky8bKfAZtTJ4XNNUReFZ9V9qLouVC8tXoBvodKZDOOOnmCWGpPw9if?=
 =?us-ascii?Q?WP5Q8Va1KeAPA9kkAQWv6vtG6/NGKEnLsgXL1LH1z4duW0uCbg1yWdzccjNb?=
 =?us-ascii?Q?Vkh0rxlo9NamC/Sb66uBie203ghS/+m4VUqpQUwcqZygm481Wtk7Mm3njYT/?=
 =?us-ascii?Q?JN6idiDk6/yHnjE1O6Rnsr7DASC0N/EM7Rac2Lv5eb2kdNklCrbtaRQBkJGF?=
 =?us-ascii?Q?nmuJG3ZOed8pI8BzjJzXOd7ARS5k+asHMMK3gGqzH4A4QwTfslDg5JQsL50o?=
 =?us-ascii?Q?5SSiYT6J4T8eozcDlw/AnCDDqdG2jKCaBMleMMhgiRmgUKLnBuf3EBLxsaWn?=
 =?us-ascii?Q?hjFymQs+tyijzlJb46DQwTDGl+oUYY98mIKy0c5D+I1XVCbzT5+xwvN37Vgt?=
 =?us-ascii?Q?4k21CFcN8XAGqBxcHcMXfaDg/GjwHd6jCybzQcBNXWCLa7QksxY/D5ekSzg2?=
 =?us-ascii?Q?AOyM5q8SZOcwY0t1FlW84tWARBtW39+64Wtq62pK5BZ4fAF4eAAcoD/2ULWX?=
 =?us-ascii?Q?rA4RxDv7g7RubPD4HAcYv9M4e/YFNFJTdVnI7WFkAG873ze8/LCnrdDWcoVr?=
 =?us-ascii?Q?N3qHX6iV/a57AcdJaNf4BLSqs3rSbH15mAExWxUOQ+ZUttiIdXtjL0HUmBtc?=
 =?us-ascii?Q?YWI7ZgjZrJ+nbL4lNlRRlexdatE+QsLsEUn9cHf4sLvZeSiPmDZWFCzV/cX1?=
 =?us-ascii?Q?pY6FugJvqIIae44jsxadClFxnVMECLV6ykDHslNjUS0KyHB/Xk9EK5VoWd2e?=
 =?us-ascii?Q?XrhyUS+nCj6eaJ+enWk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be818c49-57f5-4b53-3e52-08db96f6510d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 03:28:06.8617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dck1Ds1arQgNNcICII/Eo6GoSUwFwpUowQSy4ugOI+kLh5i9cqPV+lGKnTxfD3dtYndK176Lsqm25pg12RicYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7014
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V5 6/9] firmware: imx: scu-irq: fix RCU complains aft=
er
> M4 partition reset
>=20
> On Mon, Jul 31, 2023 at 05:04:46PM +0800, Peng Fan (OSS) wrote:
> > From: Robin Gong <yibin.gong@nxp.com>
> >
> > Use blocking_notifier_chain instead of atomic_notifier_chain,
> > otherwise below RCU complains would come out since
> > unregister/register_virtio_device
>=20
> s/complains/complaint, and in subject too.
>=20
> > () will issue mbox message (mbox_send_message() is blocking) again
> > after
>=20
> The () should be on the same line as register_virtio_device.
>=20
> > received M4 partition reset. Actually, no need atomic for notifier
> > which
>=20
> there is no need of atomic for ...?

I'll rephase the commit log in v6. There is no need to use atomic
notifier for scu irq notification.

Thanks,
Peng.

>=20
> Shawn
>=20
> > is so tough for user since this notifier is called in worker instead
> > of interrupt handler directly.
> >
> > [  389.706645] i2c-rpmsg virtio0.rpmsg-i2c-channel.-1.2: i2c rpmsg
> > driver is removed [  389.767362] Wait for remote ready timeout, use
> first_notify.
> > [  389.774084] ------------[ cut here ]------------ [  389.778729]
> > WARNING: CPU: 0 PID: 397 at kernel/rcu/tree_plugin.h:293
> > rcu_note_context_switch+0x34/0x338
> > [  389.788131] Modules linked in:
> > [  389.791195] CPU: 0 PID: 397 Comm: kworker/0:13 Not tainted
> > 5.4.0-rc5-02977-g08f78722f07b #26 [  389.799633] Hardware name:
> > Freescale i.MX8DXL Phantom MEK (DT) [  389.805481] Workqueue: events
> > imx_scu_irq_work_handler
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/firmware/imx/imx-scu-irq.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/firmware/imx/imx-scu-irq.c
> > b/drivers/firmware/imx/imx-scu-irq.c
> > index d9dcc20945c6..4408f150b3d5 100644
> > --- a/drivers/firmware/imx/imx-scu-irq.c
> > +++ b/drivers/firmware/imx/imx-scu-irq.c
> > @@ -42,25 +42,25 @@ struct imx_sc_msg_irq_enable {
> >
> >  static struct imx_sc_ipc *imx_sc_irq_ipc_handle;  static struct
> > work_struct imx_sc_irq_work; -static
> > ATOMIC_NOTIFIER_HEAD(imx_scu_irq_notifier_chain);
> > +static BLOCKING_NOTIFIER_HEAD(imx_scu_irq_notifier_chain);
> >
> >  int imx_scu_irq_register_notifier(struct notifier_block *nb)  {
> > -	return atomic_notifier_chain_register(
> > +	return blocking_notifier_chain_register(
> >  		&imx_scu_irq_notifier_chain, nb);
> >  }
> >  EXPORT_SYMBOL(imx_scu_irq_register_notifier);
> >
> >  int imx_scu_irq_unregister_notifier(struct notifier_block *nb)  {
> > -	return atomic_notifier_chain_unregister(
> > +	return blocking_notifier_chain_unregister(
> >  		&imx_scu_irq_notifier_chain, nb);
> >  }
> >  EXPORT_SYMBOL(imx_scu_irq_unregister_notifier);
> >
> >  static int imx_scu_irq_notifier_call_chain(unsigned long status, u8
> > *group)  {
> > -	return atomic_notifier_call_chain(&imx_scu_irq_notifier_chain,
> > +	return blocking_notifier_call_chain(&imx_scu_irq_notifier_chain,
> >  		status, (void *)group);
> >  }
> >
> > --
> > 2.37.1
> >