Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V5 5/9] firmware: imx: scu: use EOPNOTSUPP
Thread-Topic: [PATCH V5 5/9] firmware: imx: scu: use EOPNOTSUPP
Thread-Index: AQHZw41v9JxAHPEEOku28K+vqFT2QK/eLcgAgAAAl5A=
Date:   Mon, 7 Aug 2023 02:57:17 +0000
Message-ID: <DU0PR04MB9417C47BDAC2BDF8D00B7DFE880CA@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230731090449.2845997-1-peng.fan@oss.nxp.com>
 <20230731090449.2845997-6-peng.fan@oss.nxp.com>
 <20230807025412.GN151430@dragon>
In-Reply-To: <20230807025412.GN151430@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?56vTm901tDRdALp8zcln4ZO3gF6W6BdolF5aPBnzyZ/nV+ptLFoWfb61h9fJ?=
 =?us-ascii?Q?er8RZzWaAC7dBpkQQCvx5+T466RfX/9TvSgsJfSjisVTUAXFWCClSlmhg0Tm?=
 =?us-ascii?Q?QXtfjBZs7ZpowE/S8AyVQAydO0w8CyjF/JicN3fK1ke1bHVQ3btwXZDAYxCy?=
 =?us-ascii?Q?iBmyDykrfTL2A7/Xnry28/6RSz0c65HGS06ilZEI0WtZ8HJspzLRiAjew2OV?=
 =?us-ascii?Q?5CuM4y1l1hrOE+teh4QJNywkl0f5sA7Y9//OA5rImWH309YdGbZFjFGfe0kX?=
 =?us-ascii?Q?5YcLuVpqvTeQos136ifLQF2d72Uylo4MD11NPHl6wbnbwzL0AdV75d6Xp9Te?=
 =?us-ascii?Q?ez8dC87bXPy6EYLWmEaRGZkVakphZuZ2xz6KP+8QeVRB1/Mesjl28fyMw46x?=
 =?us-ascii?Q?HLlUuST1DLq3zmFjgEPJbUagdf7A+DDV7njcljfXLTYV2JbJ8glPMUAiWFRu?=
 =?us-ascii?Q?LoZFybeQpsONAXeyZBA+jGFDiDL/jIJNaBaDCoAge7uUlbmUWVVe7QPYGdI+?=
 =?us-ascii?Q?cdzeHV4YKSfkLrSTUvi2n483kkKWmqxa+TsfZn+NRsuYfJ3BLQ2pboubGgA+?=
 =?us-ascii?Q?jv/s3ENJw7vDrQytCRQcUEbXxnVtiOsmUAb89spXEa5xBWIXEzrTWySFhKlq?=
 =?us-ascii?Q?3G8qPQLisMGN8KPsZp+09vYt6SnlLWv7h9q12wyCxGqkteVbtpyJUBowku03?=
 =?us-ascii?Q?VGU+Z6SwX5EPPE409GwTS0GgC8njCd4JqYM9zpufHM0JWAbhAD2fIDpCRByR?=
 =?us-ascii?Q?kqvw+ReVRkUNDT8V2P7xQIbDmJaaqdKsrP994ko2oPaV+YzPHEEn/3MiZpmE?=
 =?us-ascii?Q?J9pvob5KPfOW2zhjL4v7vSaiAf7dyyjj6LBmm+lTnboQqDy3KqXKXtwj/y0o?=
 =?us-ascii?Q?fpz459txfXUNnx2J+Doeb2b1zroSsCvHpsf029Founx41kBQ0SCyuOT6nwSA?=
 =?us-ascii?Q?PJO0hLoc5sa8IdbIqWZcv/cmCtnGxcGQ1NbgwKKCH6IzYL4VgnCxHnAwTjf2?=
 =?us-ascii?Q?0ivpp9r/Z8+KnR/nn7tDCBtRTgqiBeC8RiC1WeLRccivgkAmwTOEoqJ1iMWB?=
 =?us-ascii?Q?Bj+y8yCDuIUwNRw5Qrc5IormiJM7t/emaO1Um8+LNO6kqLqITQDDM4MzcWHC?=
 =?us-ascii?Q?woHAH2uqldZ+mQyodG9DrQ27Ukj3s+HUhAcXMU3cUyjDIfAPZvWEfu7/uWjz?=
 =?us-ascii?Q?DDMdhGMPVxmzT6OPkjQaTjp6k0lOX9v/4BQqpGmOI0CVqWc/KTIUSvEHtq6P?=
 =?us-ascii?Q?UJ3SzQ0iq4SZgeTcaxoWJ7tCD2RxE6oGuUxA1FDbvILXjcq/GaHfDYyOKWC0?=
 =?us-ascii?Q?rinTvM0/3wI87+fKeZX7ZJPbDs6rY/2lSuOP3v36M40NC2GAQvEScOdC9i+/?=
 =?us-ascii?Q?5IcfS2BFJih9i2uCZka10KDKg2/qkz3L820x+41qNzpfCvCUnQzWsqVYFKec?=
 =?us-ascii?Q?VS2kpGbSDsLr/U0izfhObriVwKLrLIVNHkhbvpr0twUzjE/ZL2PpDXFhtD/5?=
 =?us-ascii?Q?5fT38ACxfMfEA8LKEpJk4bJJvpsQCRP3+Rp9uAvtEBLcWM46gg105SZpEK+s?=
 =?us-ascii?Q?gSOTgP+2ywnfBtiMnoY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d8fdac7-cc3a-4ae2-e0b3-08db96f202d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 02:57:17.6195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pFn7I5BY6LscgLXIshOwTRLnP2jSTYBOYASzcFztJy5/cl5FjzutTJ/TRrUusek9S2tGJlszTbfgvEh7bRnyFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9508
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn,

> Subject: Re: [PATCH V5 5/9] firmware: imx: scu: use EOPNOTSUPP
>=20
> On Mon, Jul 31, 2023 at 05:04:45PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > EOPNOTSUPP is preferred than ENOTSUPP.
>=20
> Could you elaborate why?

From checkpatch.pl:
"ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP"
I could add this in commit message if you prefer.

Thanks,
Peng.

>=20
> Shawn
>=20
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  include/linux/firmware/imx/sci.h | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/firmware/imx/sci.h
> > b/include/linux/firmware/imx/sci.h
> > index 5cc63fe7e84d..7fa0f3b329b5 100644
> > --- a/include/linux/firmware/imx/sci.h
> > +++ b/include/linux/firmware/imx/sci.h
> > @@ -25,27 +25,27 @@ int imx_scu_soc_init(struct device *dev);  #else
> > static inline int imx_scu_soc_init(struct device *dev)  {
> > -	return -ENOTSUPP;
> > +	return -EOPNOTSUPP;
> >  }
> >
> >  static inline int imx_scu_enable_general_irq_channel(struct device
> > *dev)  {
> > -	return -ENOTSUPP;
> > +	return -EOPNOTSUPP;
> >  }
> >
> >  static inline int imx_scu_irq_register_notifier(struct notifier_block
> > *nb)  {
> > -	return -ENOTSUPP;
> > +	return -EOPNOTSUPP;
> >  }
> >
> >  static inline int imx_scu_irq_unregister_notifier(struct
> > notifier_block *nb)  {
> > -	return -ENOTSUPP;
> > +	return -EOPNOTSUPP;
> >  }
> >
> >  static inline int imx_scu_irq_group_enable(u8 group, u32 mask, u8
> > enable)  {
> > -	return -ENOTSUPP;
> > +	return -EOPNOTSUPP;
> >  }
> >  #endif
> >  #endif /* _SC_SCI_H */
> > --
> > 2.37.1
> >