Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 10:11:24 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
CC:     Pavan Kondeti <quic_pkondeti@quicinc.com>,
        Rohit Agarwal <quic_rohiagar@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_jackp@quicinc.com>
Subject: Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi
Message-ID: <161713d4-1c95-4822-ac66-dbc7c2d8b421@quicinc.com>
References: <1690970366-30982-1-git-send-email-quic_rohiagar@quicinc.com>
 <1690970366-30982-4-git-send-email-quic_rohiagar@quicinc.com>
 <ce1af969-427a-3e4d-e85c-32d629755d9a@linaro.org>
 <bb374ec4-3dfa-42f1-dffb-fc8505625b73@quicinc.com>
 <2e97b032-4ca5-e59c-c891-2ed9ca39d237@linaro.org>
 <7941f5de-547c-4a92-9af1-a1c0add1ace4@quicinc.com>
 <dfe57d75-f0ff-41fb-bc81-0dc84dcfef7e@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dfe57d75-f0ff-41fb-bc81-0dc84dcfef7e@linaro.org>
Precedence: bulk

On Fri, Aug 04, 2023 at 06:58:34PM +0200, Konrad Dybcio wrote:
> On 3.08.2023 07:06, Pavan Kondeti wrote:
> > 
> > On Wed, Aug 02, 2023 at 03:14:19PM +0200, Konrad Dybcio wrote:
> >> On 2.08.2023 15:13, Rohit Agarwal wrote:
> >>>
> >>> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
> >>>> On 2.08.2023 11:59, Rohit Agarwal wrote:
> >>>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
> >>>>>
> >>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> >>>>> ---
> >>>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
> >>>>
> >>>> [...]
> >>>>
> >>>>> +
> >>>>> +??????? pm7550ba_eusb2_repeater: phy@fd00 {
> >>>>> +??????????? compatible = "qcom,pm8550b-eusb2-repeater";
> >>>> A new compatible should be introduced, so that it goes like this:
> >>>>
> >>>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
> >>> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
> >>> Should every soc have a compatible string?
> >> If it turns out that we need to add a quirk for PM7550BA 3 years down
> >> the line, this approach lets us fix it for users that never updated
> >> their device trees.
> >>
> > 
> > Trying to make my understanding clear.
> > 
> > eUSB repeater is a peripheral in the PMIC. Do we need a separate
> > compatible even if the peripheral is same in two different PMIC chips?
> > I believe eUSB peripheral has some identification registers to apply any
> > quirks in future.
> Perhaps, but keeping the compatible tied to the specific hardware is
> the way to go with the device tree. Most components don't have such
> information avaiable, and since at introduction time there wasn't
> any better name for it, "pm8550b-eusb2-repeater" was chosen.
> 

Thanks for the clarification and guidance. We can introduce a new
compatible and use qcom,pm8550b-eusb2-repeater as generic binding.

Thanks,
Pavan