Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 07 Aug 2023 04:13:05 +0000
To:     Masahiro Yamada <masahiroy@kernel.org>
From:   Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: merge_config: Add flag to prevent unsetting config option
Message-ID: <875y5rsd6c.fsf@protonmail.com>
In-Reply-To: <CAK7LNAR_Egr+G9_HmGfrmFAEQ0Tznmbff0w9cJ=1biV5P4PmNQ@mail.gmail.com>
References: <20230729214138.79902-1-sergeantsagara@protonmail.com> <CAK7LNAR_Egr+G9_HmGfrmFAEQ0Tznmbff0w9cJ=1biV5P4PmNQ@mail.gmail.com>
Feedback-ID: 26003777:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Sun, 06 Aug, 2023 23:19:55 +0900 "Masahiro Yamada" <masahiroy@kernel.org=
> wrote:
> On Sun, Jul 30, 2023 at 6:42=E2=80=AFAM Rahul Rameshbabu
> <sergeantsagara@protonmail.com> wrote:
>>
>> Overriding a previously defined entry for a config option with 'is not s=
et'
>> may be undesirable in some fragment configuration setups.
>
> Then, you should remove the 'is not set' entry from the fragment.

I had a feeling that was the expectation. Just for reference, my flow
for generating fragments looks like the following.

  1. make allnoconfig
  2. make menuconfig   # select the options that I desire for the fragment

We can drop this patch if this is the expected developer flow. I
realized that overriding with 'is not set' entries in a fragment is
likely desirable, so I made this behavior change as part of a flag that
can be set by the user.

--
Thanks,

Rahul Rameshbabu