Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759920AbXJaQBS (ORCPT ); Wed, 31 Oct 2007 12:01:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756571AbXJaQBF (ORCPT ); Wed, 31 Oct 2007 12:01:05 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:54771 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbXJaQBE (ORCPT ); Wed, 31 Oct 2007 12:01:04 -0400 Subject: Re: sched: fix new task startup crash From: Peter Zijlstra To: Srivatsa Vaddagiri Cc: Ingo Molnar , linux-kernel Content-Type: text/plain Date: Wed, 31 Oct 2007 17:00:59 +0100 Message-Id: <1193846459.27652.220.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit X-Bad-Reply: 'Re:' in Subject but no References or In-Reply-To headers Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 18 Hi, Commit: b9dca1e0fcb696716840a3bc8f20a6941b484dbf seems to me that by calling enqueue_fair_task() from task_new_fair() is wrong. The wakeup=1 in enqueue_fair_task() will cause all non-top sched_entities to be re-positioned by place_entity(). Although the current implementation thereof seems to avoid doing something horrible. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/