Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <horms@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp counter
 atomic update feature
Thread-Topic: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp counter
 atomic update feature
Thread-Index: AQHZyPou6tZoCYwWUU6g8m09WQMaWg==
Date:   Mon, 7 Aug 2023 06:41:22 +0000
Message-ID: <BY3PR18MB4707D17FD94F2700F9E85226A00CA@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230804093014.2729634-1-saikrishnag@marvell.com>
 <ZM4zmG55sEr9b62l@vergenet.net>
In-Reply-To: <ZM4zmG55sEr9b62l@vergenet.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CQDcr7KMpPrXRWNnnDh9YQ/cryFXNkYVWm/QTCscYRBHTv4GvEq/E1Wt7bYz?=
 =?us-ascii?Q?tb1zFbOYvvrn79MMqUlXrDOs3ZTda/rpeQ2GagOsDqPUvyWeMr2SRSwStOZI?=
 =?us-ascii?Q?RmHXrha2Yd6iFPFWQDbOgScrH4tuOhU0v65u53nK46fSO6MUDLYsJ6G3C5gB?=
 =?us-ascii?Q?LSzNzHB0YhPnRlWTis/Zw35QWBoil1d8ZMz/upWTCRBnDNWFCQLjuRcbV3cZ?=
 =?us-ascii?Q?AV3hdM2sltQmw1rJuBXewWLpSCVrgg8MAah0/j2v9IEUMzCulKtL+zFll/x0?=
 =?us-ascii?Q?s5EPBWV6Qe+PwD+oVnShiNw7TI9TjUQyJmockfeCHOoPEVTvBJ4pj12ppKOD?=
 =?us-ascii?Q?SJkELSTsQMqZODbKtrnA7f/6IcOiAyOqiNysSt62dmlp98nPf7UyE3zwm8t+?=
 =?us-ascii?Q?TUmLDT1Ed0Mt9ZsVqcd1zLEkTIY9J/hCVn3HLbMwxvQV7cCKLzOr5IIJQqYx?=
 =?us-ascii?Q?97GCnu9+goFotllVLcHEBoqVW1uEAF1JtvNU9GnOPaW252miLhk924HigO5C?=
 =?us-ascii?Q?Dn1OoUqAL4XPh0wFJhW6KSIav1G7E8Hi3iTWSP/3MwtxPrlhp9/jWEeef+qy?=
 =?us-ascii?Q?j4/GaTO1uWy0AKx4RXxaJdlGxLYW/QSPzARosrvx3FzQ5M3wEaRjrc+xPrZG?=
 =?us-ascii?Q?pz82TlTKdWbj8t2PUms23Mgl/34uUk46RrubIMlJ3DTIT22FJmQ+u+1fBe2F?=
 =?us-ascii?Q?L/KZ41WPZBOD0UO+U9hlqHmUT5iMhaWhOxSRwpVCRDwsfTdUPuffgXAIKyK2?=
 =?us-ascii?Q?q3L599WSoc1CHGxl953uIQv5OcHUIrrzcVtDSzvB+8SW1w10xsMCaIVjYC57?=
 =?us-ascii?Q?xHAXBG3mlYo2eiqqM7PpLDaOJVyc3WHCallsaLDXEwmQjxa55X2VCuv0/fj+?=
 =?us-ascii?Q?5c69dm4KrtZNcIRcv/6QZPXkxH1vtu6gmAP6KW+mpYYcYsjAoCiSyMnZR5k4?=
 =?us-ascii?Q?KZAdB7MMCom5gJOQZCoF+GkeEqa7AQy3tYOpP9beoQqU2dKqeSCwBd0nCQ9O?=
 =?us-ascii?Q?++8auwXo8gL8e+SlM2+kyJ2tu/iZWuULba9xzVtYw/pKlY9yrqMvz36ZeE76?=
 =?us-ascii?Q?iegsihMV+/j/lUAmE7B2Anky+vjUJ6xx5MstG6wi+EiVZ0p8UWZn8gvZWc50?=
 =?us-ascii?Q?1eYx6dYBpkJejUEk4KcDRbmZbXMh91/pKg2UI/sVqAW7ZE9WCzmg+s4j1tv5?=
 =?us-ascii?Q?Ys/eRx4VcYM1zkZohKgiGSMXfkJzOxdarIKVqWEHb11V0y6rOwq76eC16IZN?=
 =?us-ascii?Q?5iSMTk1UMBQgr+AfI6j88XqLre3FhmI1iW74l4fR2aj/HLwwLRPAYdCiT3hc?=
 =?us-ascii?Q?QKCqNbfmMpFlB26rzYejf4s1YYidzQf4ssUP2pLya6IMWlCowrldMEcZ+i+A?=
 =?us-ascii?Q?mIEJ/KbWAWv1AF269mSR2eSfIwExHTHrEKhX25TBDTO9U5hnrmwRqwOJoYlw?=
 =?us-ascii?Q?YUe5NqDOUeYf2vbnlnIDh1nilxZEZTFOTdL/SQe0KfqNoO6R92ywS45oPP3a?=
 =?us-ascii?Q?uv88JaPJNR6uJaE9d4A6E0BacPX78LlSqeIHIjpwfUosWYjt3uSlXneDu1Kj?=
 =?us-ascii?Q?qnzV7kCqksF+9IaxCCvTjzwKa4bIHi2sa+LtqEgb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 233febba-ce12-4863-9f3f-08db971150b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 06:41:22.7031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wiTvEJM5+0jIST1H29BCgopib0XMDBwvuSzXTtoYKpBKaE+YetDGPN2wXvxsu7azLM+f6PMaU39+7uljc+fezQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB5141
X-Proofpoint-GUID: WfPbRIJ9J3NkDVHUUOz9KbwKdDkftMYJ
X-Proofpoint-ORIG-GUID: WfPbRIJ9J3NkDVHUUOz9KbwKdDkftMYJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-07_04,2023-08-03_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Saturday, August 5, 2023 5:04 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> richardcochran@gmail.com; Naveen Mamindlapalli
> <naveenm@marvell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp
> counter atomic update feature
>=20
> On Fri, Aug 04, 2023 at 03:00:14PM +0530, Sai Krishna wrote:
> > Some of the newer silicon versions in CN10K series supports a feature
> > where in the current PTP timestamp in HW can be updated atomically
> > without losing any cpu cycles unlike read/modify/write register.
> > This patch uses this feature so that PTP accuracy can be improved
> > while adjusting the master offset in HW. There is no need for SW
> > timecounter when using this feature. So removed references to SW
> > timecounter wherever appropriate.
> >
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
>=20
> ...
>=20
> >  struct npc_get_field_status_req {
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
>=20
> ...
>=20
> >
> > -static bool is_ptp_tsfmt_sec_nsec(struct ptp *ptp)
> > +static inline bool is_tstmp_atomic_update_supported(struct rvu *rvu)
>=20
> Hi Sai,
>=20
> Please avoid using the inline keyword for functions in .c files.
> Unless there is a demonstrable advantage to doing so it should be left up=
 to
> the compiler to inline or not.

Ok, will remove inline keyword and submit V2 patch.

Thanks,
Sai
>=20
> ...
>=20
> --
> pw-bot: changes-requested