Date: Wed, 31 Oct 2007 12:20:16 -0400
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: Paul Jimenez <pj@place.org>, rgooch@atnf.csiro.au,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtrr use type bool
Message-ID: <20071031162016.GD27646@csclub.uwaterloo.ca>
References: <20071031035718.A1D9E8B2A@place.org> <47289EE3.8080706@student.ltu.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47289EE3.8080706@student.ltu.se>
User-Agent: Mutt/1.5.13 (2006-08-11)
From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 32

On Wed, Oct 31, 2007 at 04:27:31PM +0100, Richard Knutsson wrote:
> Paul Jimenez wrote:
....
> >-			usage_table[i] = usage_table[replace] + !!increment;
> >+			usage_table[i] = usage_table[replace] + increment;
> >  
> This seems a bit strange, using a boolean as an integer (yes I know, it 
> works but semantically...). What about:
> 
> +			usage_table[i] = usage_table[replace];
> +			usage_table[i] += increment ? 1 : 0;

What is wrong with:
usage_table[i] = usage_table[replace];
if (increment)
	usage_table[i]++;

I hate code with the '?' operator in general.  It's a conditional either
way, and at least this way you wouldn't even have to do a store in one
of the two cases 9although if the compiler can't figure out that is the
case already, then it really sucks).

Pauls code at least didn't involve a conditional at all, but on the
other hand is less clear to read.

--
Len Sorensen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/