Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 10:07:24 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Nishanth Menon <nm@ti.com>
Cc:     Dhruva Gole <d-gole@ti.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] pinctrl: single: Add compatible for ti,am625-padconf
Message-ID: <20230807070724.GN14799@atomide.com>
References: <20230805045554.786092-1-d-gole@ti.com>
 <20230805171508.schg4xquoa24klk5@october>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230805171508.schg4xquoa24klk5@october>
Precedence: bulk

* Nishanth Menon <nm@ti.com> [230805 17:15]:
> On 10:25-20230805, Dhruva Gole wrote:
> > From: Tony Lindgren <tony@atomide.com>
> > +static const struct pcs_soc_data pinctrl_single_am625 = {
> > +	.flags = PCS_QUIRK_SHARED_IRQ | PCS_CONTEXT_LOSS_OFF,
> > +	.irq_enable_mask = (1 << 29),   /* WKUP_EN */
> > +	.irq_status_mask = (1 << 30),   /* WKUP_EVT */
> > +};
> > +
> 
> Why cant we set this in the k3-pinctrl.h and set it once?

Good idea to define the bit offsets k3-pinctrl.h instead of magic numbers
here :)

> The event will not be generated until wakeup daisy chain is triggered
> anyways.

Yup, and having that happen is enough to show the wake-up reason with
grep wakeup /proc/interrupts :)

> Have you looked at all the padconf registers across devices to ensure
> the WKUP_EN/EVT bits are present? daisy chain feature is used elsewhere
> as well.

The lack of bits at least earlier just meant that attempting to use a
wake-up interrupt would just never trigger. Worth checking though.
Dhruva, care to check if some padconf register have reserved bits for
29 and 30 that might be set high by default?

Regards,

Tony