Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 09:30:40 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@gmail.com>
Cc:     John Watts <contact@jookia.org>,
        Maksim Kiselev <bigunclemax@gmail.com>, aou@eecs.berkeley.edu,
        conor+dt@kernel.org, davem@davemloft.net,
        devicetree@vger.kernel.org, edumazet@google.com,
        krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-sunxi@lists.linux.dev, netdev@vger.kernel.org,
        pabeni@redhat.com, palmer@dabbelt.com, paul.walmsley@sifive.com,
        robh+dt@kernel.org, samuel@sholland.org, wens@csie.org,
        wg@grandegger.com
Subject: Re: [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller
 nodes
Message-ID: <20230807-thorn-sponge-bd59b35feebe-mkl@pengutronix.de>
References: <20230721221552.1973203-4-contact@jookia.org>
 <2690764.mvXUDI8C0e@jernej-laptop>
 <ZM8-yfRVscYjxp2p@titan>
 <4848155.31r3eYUQgx@jernej-laptop>
 <20230807-denatured-gangrene-e6f37ba5f9ef-mkl@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="llt7j25uzpb3nty6"
Content-Disposition: inline
In-Reply-To: <20230807-denatured-gangrene-e6f37ba5f9ef-mkl@pengutronix.de>
Precedence: bulk


--llt7j25uzpb3nty6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.08.2023 09:16:41, Marc Kleine-Budde wrote:
> On 06.08.2023 13:42:28, Jernej =C5=A0krabec wrote:
> > Dne nedelja, 06. avgust 2023 ob 08:33:45 CEST je John Watts napisal(a):
> > > On Sat, Aug 05, 2023 at 07:49:51PM +0200, Jernej =C5=A0krabec wrote:
> > > > Dne sobota, 05. avgust 2023 ob 18:51:53 CEST je John Watts napisal(=
a):
> > > > > On Sat, Aug 05, 2023 at 07:40:52PM +0300, Maksim Kiselev wrote:
> > > > > > Hi John, Jernej
> > > > > > Should we also keep a pinctrl nodes itself in alphabetical orde=
r?
> > > > > > I mean placing a CAN nodes before `clk_pg11_pin` node?
> > > > > > Looks like the other nodes sorted in this way...
> > > > >=20
> > > > > Good catch. Now that you mention it, the device tree nodes are so=
rted
> > > > > by memory order too! These should be after i2c3.
> > > > >=20
> > > > > It looks like I might need to do a patch to re-order those too.
> > > >=20
> > > > It would be better if DT patches are dropped from netdev tree and t=
hen
> > > > post
> > > > new versions.
> > > >=20
> > > > Best regards,
> > > > Jernej
> > >=20
> > > Agreed. Is there a way to request that? Or will the maintainer just r=
ead
> > > this?
> >=20
> > Hopefully it will.
>=20
> I'm just catching up on last week's post (I had a long off-line
> weekend).
>=20
> I'll revert the DT changes and send a PR to net-next.

Here's the revert:

| https://lore.kernel.org/all/20230807-riscv-allwinner-d1-revert-can-contro=
ller-nodes-v1-1-eb3f70b435d9@pengutronix.de/

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--llt7j25uzpb3nty6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmTQnZ0ACgkQvlAcSiqK
BOgJNgf/YNyefVqQQvPihS3Ab6HIs4mMvN3hqRLH4teavOkBVATTaG35qXtZqgt/
teGW+v3n/TlqwvMvgk9znMb2nYDylooyDvaNNOaa+SPjOTK0yzyBLXTeWaMbCINO
ZGAWV3l83jm8I08RYOfZK/pe4R3kUGj+JXxqjc6T5tScEgix6Bqbdy6Y1ebq81el
O+l7Nd/rYDPXqo8AHishESrhRdxGQX0aVvFasOcGNrZtesOdm/xunRwhw8iV3uDE
uKG7h+OStWf4Ymff8uGd8GgYkJ6DSIQyVL5Qwuw4YVd95TSb2I4Cxhm0or9imY4Y
iOuWa/BBZ47vOWLBOTfAvba9pbRatA==
=XMKz
-----END PGP SIGNATURE-----

--llt7j25uzpb3nty6--