Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 13:28:17 +0530
From:   Jai Luthra <j-luthra@ti.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        <niklas.soderlund+renesas@ragnatech.se>,
        Benoit Parrot <bparrot@ti.com>,
        Vaishnav Achath <vaishnav.a@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>,
        <devarsht@ti.com>
Subject: Re: [PATCH v8 04/16] media: cadence: Add support for TI SoCs
Message-ID: <nuvsezmkvihi4vxcfx6ao2l6nxtwb7m5edaogjv7e5xsjryass@s3gpozvacw7s>
References: <20230731-upstream_csi-v8-0-fb7d3661c2c9@ti.com>
 <20230731-upstream_csi-v8-4-fb7d3661c2c9@ti.com>
 <000f45c5-d7dd-237e-1e1b-72056acd4af1@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2ijfxspukfjubg5h"
Content-Disposition: inline
In-Reply-To: <000f45c5-d7dd-237e-1e1b-72056acd4af1@linaro.org>
Precedence: bulk

--2ijfxspukfjubg5h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Krzysztof,

Thanks for the review.

On Aug 05, 2023 at 23:06:43 +0200, Krzysztof Kozlowski wrote:
> On 31/07/2023 10:29, Jai Luthra wrote:
> > Multiple TI SoCs (J721E, AM62) use this CSI2RX receiver, integrated with
> > an external DPHY and a pixel-grabber IP that unwraps the pixel data and
> > send it to memory via DMA.
> >=20
> > Add a separate compatible for the TI-specific version of this IP.
> >=20
> > Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > ---
> > New in v8
> >=20
> >  drivers/media/platform/cadence/cdns-csi2rx.c | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/med=
ia/platform/cadence/cdns-csi2rx.c
> > index 0d879d71d818..b087583d636f 100644
> > --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> > @@ -559,6 +559,7 @@ static void csi2rx_remove(struct platform_device *p=
dev)
> > =20
> >  static const struct of_device_id csi2rx_of_table[] =3D {
> >  	{ .compatible =3D "starfive,jh7110-csi2rx" },
> > +	{ .compatible =3D "ti,j721e-csi2rx" },
>=20
> Why do you need it? It's redundant - already compatible with cdns. No
> need to add empty match entries.
>=20

Understood, will drop this patch in the next revision and re-introduce=20
later whenever we add something SoC specific in the driver.

> >  	{ .compatible =3D "cdns,csi2rx" },
> >  	{ },
>=20
>=20
> Best regards,
> Krzysztof
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--2ijfxspukfjubg5h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmTQpBcACgkQQ96R+SSa
cUW4DxAAuOkfKD+dnrSbirnBn5H8fc4jAXTQVeThmFbBa8Mvbw7tLvuSQfffgaAe
YVAgf2QOV+RN9nO8B4kkRGg+QqjmVD06MqcbwYwlzrEKZoQxxhlPSFczodKg24aR
PDgEkGquRZhWkG1Asrw3PwzV2lbQ/JTfuoHQNdvUkJ/61H/WKJMDGjaFJmi+/GIL
Rqxdo8zLIA89Xkeja4KZKQlFCwmKvfHXeNqNCn3CTFt03mqj91DVHPIWyH6MsSqi
D5ei9DZAJIQ3yzk2/H9W3GJy33J5+KMnCUG3t67AR1O+KEUUAO/j3DGSB86i/bF7
m7fn7mjn88FB7XoNcDesxJGfNK0sATX/yNOWZROrxUxnMB+E4CC4XkncB+1tMDhG
uOLZ9JRRjvHZ3yZkxSaolZQd9PwpRwswMW/nTJ1aKfzFJWzIAaScEWDqAJ2rpm53
mjTcHFoED49PmKIjBKRZATOYNaEid8zPzPuIy4NFdr0iG87cR9d/k15hoVlE8olr
6VxPvIw2a0SdgROH1J7GF8iY4AO3ZzZcVlZyFU4qjnT8ggGoSHFvNRAdHZnYAcTe
NWqmaqAHE9FzzCJ0KwX8ZNc9MBkUSh2v0PERgaJ3/QJFDcSoUr4iAkQIRAF+ki2t
Es+LUolItJVoV6z9GExGY0l99/ocuyw/LFcbe7gE1GiHlIj3hXw=
=3zUg
-----END PGP SIGNATURE-----

--2ijfxspukfjubg5h--