Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp2699347rwb; Mon, 7 Aug 2023 01:48:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsdnU4siHiAY9PQSQOgx+Y6djXVJiboXzxzG/l6SgHvMlZ00PhnScO6Ea9+gyOKeD8ZVNI X-Received: by 2002:a05:620a:f0f:b0:767:fbe:f4b with SMTP id v15-20020a05620a0f0f00b007670fbe0f4bmr9152415qkl.72.1691398137111; Mon, 07 Aug 2023 01:48:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691398137; cv=none; d=google.com; s=arc-20160816; b=dfJDsiw/zOH+QUz3BCV+4J51VDUCmQWF6z7lkNvVu8Gboyi/BeGtBcuTfRe07DEIc/ ZgLD9+y2HpuaFp0d4foBK4kgVBkBroIBEKkv0JAZ9hOc4Z5LjoLt5gS7nytLQ0M1Us5C bTtyWvRqHYozRji2kP//aHpP/hTSpPiGEMcmDSr8XoM/XJQ41oqYXVBLtzU6g9PaekUg Jshsto3tCbegsCKtRppmrRP4GUE2t/ITSg59MrO2Tfp+kM3Aw2FDcNWzOZ50T2vcwovx Qb/oMVJVDb/Te5+oSuot/WdqTz94eIJvLukOF+cj+SfvI8qZ/bF+gInGjLkXMMau5qEn z+nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LkWwtZsl/ZS2ofti0t2kC2R0Fufo15InoHqryA/vhoA=; fh=2Jsj58Uu81wSjeGAY+4sOMh0Annh6sJflJho2D/rH2Q=; b=LCc21QLO94xWfA71nojJnS+t8duya5YCSgXIliVqbzcQWH4OrUBjaEyDAqr7vq7hde cr87+Dta9HdOm0N0zWozi7NFok/zwXUnRrKFWD0Nnhz2paJ9ooXo+Z12XLV6xJHYMAjG wB7vWJtJvOXZ8sk4d/LT8JW4m5F3ZdZHXiCnHtzdDha70A46/tqTpBXE2oCwZppdIYKF 7g0874Fs8Dqi5uZHNeP+ysBuXTE8najWSyJe/ARKeSg7sDTDl8FCJblOOdSfj0XyKUhN hptqtPLD6MLcPRDAspMOUFkCyuQgaVhgr8lR+wQfRYh21k9K/rpXst5aO99EhSTiZu9a 68rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=ZbkBirJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a63fc08000000b00563da4d2a70si5020095pgi.364.2023.08.07.01.48.45; Mon, 07 Aug 2023 01:48:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=ZbkBirJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbjHGHxx (ORCPT + 99 others); Mon, 7 Aug 2023 03:53:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbjHGHxl (ORCPT ); Mon, 7 Aug 2023 03:53:41 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A4151BC2 for ; Mon, 7 Aug 2023 00:53:18 -0700 (PDT) X-UUID: 73fcd5ac34f711ee9cb5633481061a41-20230807 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=LkWwtZsl/ZS2ofti0t2kC2R0Fufo15InoHqryA/vhoA=; b=ZbkBirJnxdcW2Wb91f84BI/K9t2jkpCNbCPfHHTZP0xMuzofUkoYh5bDH49O8kTzqt4WM9IEidqxxj8O5QiZx6HfoCB3iRzhrZQMDz8JvZwyXQEReeoKuIfjvBJepxDJ2EP1lPYmEFMmXNMNaUwzuoJZAedflFDTT1YnlSu/Lak=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.30,REQID:85cb0795-ced5-4932-a652-3b7a648eacd0,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:1fcc6f8,CLOUDID:9c59f8a0-0933-4333-8d4f-6c3c53ebd55b,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 73fcd5ac34f711ee9cb5633481061a41-20230807 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 224011429; Mon, 07 Aug 2023 15:53:10 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by MTKMBS14N2.mediatek.inc (172.21.101.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 7 Aug 2023 15:53:09 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 7 Aug 2023 15:53:09 +0800 From: Lecopzer Chen To: CC: , , , , , Subject: Re: [PATCH] ARM: ptrace: fix scno of -1 cause SIGILL Date: Mon, 7 Aug 2023 15:53:09 +0800 Message-ID: <20230807075309.6188-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230724121655.7894-1-lecopzer.chen@mediatek.com> References: <20230724121655.7894-1-lecopzer.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In commit [1], the -1 scno is used as a special scno when the task's > syscall is traced. > After commit [2], PTRACE_SET_SYSCALL will always mask syscall with > __NR_SYSCALL_MASK, this makes the condition `cmp scno, #-1` broken, > and some test like Android VTS[3] is also failed because SIGILL > interrupt the test program. > Let's test with `and` logic with #0x0ff000. Instead of #__NR_SYSCALL_MASK > because of the constraint of ARM Operand2 rules and avoid conflicting > with ARM private syscall. ... Please follow the commit from Kees below and ignore this patch, thanks. https://lore.kernel.org/all/20230804071045.never.134-kees@kernel.org/