Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a2c7977-2337-40d5-449b-18a3e3711686@oracle.com>
Date:   Mon, 7 Aug 2023 10:19:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v6 1/7] perf pmu: "Compat" supports matching multiple
 identifiers
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>
References: <1691394685-61240-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1691394685-61240-2-git-send-email-renyu.zj@linux.alibaba.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1691394685-61240-2-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXQ1b0Yzb3dPaFRvdi91WksweTdoSkZEMnVGSGhSTDdjMVpTL0hrRWtXZVRB?=
 =?utf-8?B?MlZhakNESkxNUlhJOGtMVkNBeVdiNjVrMWdHWGZ5N1BvV0FCTjFxdS81eVNB?=
 =?utf-8?B?MGs4cHBaL05EY1BLSHlHZ2xEdG5xZWxBVy9wR3o4YW1YaGJFNzRNY29HZFIw?=
 =?utf-8?B?RWtxV3l0NkdLYS9DNFJMa2tuMVVRSy8wTG0zT0VNTUpsUDcvZzFxOHBVZkt0?=
 =?utf-8?B?MU94cTBPWkdJTkJFNDUvQTl3WklVVmNKQjBnOEYyMHFFSjN6QStYQkZ5cGRL?=
 =?utf-8?B?aHVIM0I5dW11WGVaVkRBMEtQeEp2Z1BPaGc2OGNNY1llOHBzMjdtTWZjVmgw?=
 =?utf-8?B?RzhlSVd5OTF6aEFrQXJ5SGxnM2NuQnRMNEh0b1ZHRFoyTzBsSnJiaG8zeWR1?=
 =?utf-8?B?L1I2L1FHbTBWWEVGU010ZEo2ZFpqdVNMZjhVcTA4ZnRHVUFVbnZGaWpqd2Zl?=
 =?utf-8?B?NTdwWjNUTTl2dWFnWDBxNUNIMi8xL1FDVEJTdVh1R2h5SEdWNEF5T3VzbWVv?=
 =?utf-8?B?L0xjMXdoNVV3ZFpCeDkydEpmRFVhRmp5dTZBU1IrWWVWdlNkMlRiQ2t3dmFm?=
 =?utf-8?B?cDBHK2M1RENCZnpmTFNLb2x3Y29CdU1WL09uOGNQMUJRMWFmSVBwbkhlUGth?=
 =?utf-8?B?OEVDSGIvMzg1V0ttbjJrM3BySEpEUWN1OVk0UnYzZTZQd2JJVGNhYURjbmwx?=
 =?utf-8?B?eTlJSFB4Zjh4ZnlOdm84VUlsZ1pQN2VhK1RFWm1memxleDdnRWQ3V08ybUl3?=
 =?utf-8?B?ZFJMWm5XZzJuOFo4TnNMalFRL3JVcGdYRlFsRE1ONm90OG9lL2g1czNxVUF2?=
 =?utf-8?B?eWpOSnVmR0hVMXVZYUtqOVMvSlJCdDQxS1RJeG5mVWx5eWx1MWtnVFlUb3pq?=
 =?utf-8?B?bEV1c2tQaXBrZkJFSjVRZkZSWmVGZXQ1WXRvYjZ6bXFRV0FGMkJvYVowU3lL?=
 =?utf-8?B?SStsMmhETGxVdGRBdVdHSFlTd1cvbE95NUZaSVpHMXFZRG5yalhxUDBveENm?=
 =?utf-8?B?cElGeWQxOHpmNi92ZUw4SGdXaDY5eEUxbnc4TGFJS2J5QzFQNFBKOG9hamoz?=
 =?utf-8?B?Q1lCOFNDNHEvR0orck9lYTBtVkFLU1pLbjVYbHJaTnIxWmRDSmhxMjl2bkMv?=
 =?utf-8?B?SWQ2RXRsM1dZYUd3WFloRzJDcHJ3VmxUcTBSTWNkeXE4WWZBN3JnVFJaajRj?=
 =?utf-8?B?d2M3aW9TRmprTGJtUHZzZ3F4Vm1WVmxCNk9sSTIycEh4OVcyK0VTeTltRlpL?=
 =?utf-8?B?TTh1WDlhVTRwS3BYV3JjZzVsYVJXMGM4eFFBNm1sa0kvckYycWpQblE3Mzdr?=
 =?utf-8?B?Y1dyQ0VIZldSK2VtQmV2V2swTGdhMzg4cnRVVitMK0dkTlBpWGRXRWNyU0Fs?=
 =?utf-8?B?dzZ1VmcwdndYU3RQTVRPbU9QMEMxYldlVkhmQXR3ZldMQWUxdzErY2tyMFBD?=
 =?utf-8?B?cStRT2ZhT0MwamowaU9ScGhjYldSc0o4d0FtelMxT0dFYXMvNWVHVmZjVXpo?=
 =?utf-8?B?MFRPZHErR0p0aTJ0V09DNW1kcjB6bHI2WWhMd1NnSTNXNmtLUUwrUG1iUWpl?=
 =?utf-8?B?eVdaYThuMm5IOU1WNjhSUHErVVYyOS92YWxMVC9lMjlWQ3lFQ1VVdThpbGlZ?=
 =?utf-8?B?WXVMMWRtcC9vY1Y2OVNmb1hsQTZNYXBXYWFOSFI1SU54Ty9seTNQWkVLU1Fh?=
 =?utf-8?B?M3hEQjB3elFJaTNRKzUwdklyVFJDbmwzczBQSjl5WDAzVG84dEs0SlJIT0J3?=
 =?utf-8?B?T2Y4SVc3S0htQld0c0pHc0RLRmxIWXVjMVZJS0cwczdzTW5tdTUydE1PYWpS?=
 =?utf-8?B?MlRtTm00a0FoRlU0cWp0NDc3dy83WExuK3dybS9BZ1JaaWZ3VXNaMUI3ckhm?=
 =?utf-8?B?THd6SDRHblNKeUlVTW9vNHZ4UUtuWEY2aG0rWWZ6aDIyYkJ4bytCQTZtek9t?=
 =?utf-8?B?OHU5MTRCWDlxU2o1bzkyWUU4d2ZFT3NRWmNmbDdRTHVTb3lhNVlBZGFVbTMw?=
 =?utf-8?B?bjFndENoRGZoK25CVlBMVkl2dnlOa2RKWDFGc2JJVkl1ZERVZHNpRFBUdHN6?=
 =?utf-8?B?RTRPNGlEYXV0T1RLUjBLTWRQS0M4N0ZWdFZqUDdLLzNjOHY1b0JTQzR3NElT?=
 =?utf-8?Q?d3igXlaML35OomL2HVeW7QBsg?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VWV5ajRqQmg0dWtOa1JCcXFQZWxEb21nZUVxdjAzQ2lJVWV4RmRhUHpKbTNp?=
 =?utf-8?B?YTRjdGhBK0RUM3phZ0VnL00vaSthZ3duZ0hub3R4N3gyTWtPczFabHJWNnlV?=
 =?utf-8?B?dDVldVJiQWNxL1d4MlM0UGJjZ0orRkVZR0J3MnpuaWhOR3NvRFY3ejg4cGNt?=
 =?utf-8?B?Q2tIUjAvZnBUdFE1YWxuaVo2aW9reVdQV1VGakJNQkF3amY1NUo0dFBsN1l5?=
 =?utf-8?B?bytIM1FBTjVCQ0RTeWZUTy9JTDZ5SXVxQS9IOFpaZXd0NkRvMUc5U09LYTJV?=
 =?utf-8?B?SjNDcmFja0JpR3lWVy9aMjFDejY2RFhyRDBpbnZPcVNXTnRpaWhaNG5UTExP?=
 =?utf-8?B?ZERScUhVaVVuek9qM1ZuclREa2xYaDNaeDlCVCtMbVdXd29WRnZsYlUwditt?=
 =?utf-8?B?WGVGZ0tiMzN2RzdTbStuRVlVUEZ1blE0WVgxaUZRa3pzaWIxK3ZzeVdzT3h1?=
 =?utf-8?B?WHpJemxveXFBalZJaUJTWFg3aWVaK0xlVUZXRHU2NXJVM3FZTm11ZGdJclJz?=
 =?utf-8?B?NFhqMUMrZWVSN0V2WE9Ka2E4UzRCSW1FM0hVNklnWW9McE16aHhjaUVEQWhn?=
 =?utf-8?B?TnJpeExlTElkUE1Ib0p4Wis5bFI4bHk0YkRXTlpJZi9KNmxYTlRSRUI0OGdP?=
 =?utf-8?B?QjlQSi9QZzN6UWVLOVNDeWJueHllUnlKWVlUMldpOFpLaTFOME8wT3pLR0NJ?=
 =?utf-8?B?ZXpYUU12YVBlYTNiTHFOem5rOXF2bjRmV0xsZ3FxU2Q1SFEydERBTzQrN0xp?=
 =?utf-8?B?Q0VqMjd1SmpIOGFsVjFNRUtzclhOVG1OOHYreWRYS05lMFNUNkx4d1RDVTd1?=
 =?utf-8?B?eGJxb080bmtSNVpvUHJ1YkRUbXQvcFhic21zOHpHY3FidnRWZnQzclRjNzBC?=
 =?utf-8?B?bjltdTB4OWxSRnFRS011akhIdHk1cHQ3aW9PbktOMkhsVG5aV1pibitjZUh5?=
 =?utf-8?B?ejB4V0g4Wk0zTGxpWjBIa1NRQWFwRU9vbXZzRU1WZDY1QUw1Qm5hRnd4SHI3?=
 =?utf-8?B?Qi9FOWFBZUtNc3B2Y3FUTTduVzNqcStacm5MQmFUM1NyMVVsUUJ1Mk16UjQz?=
 =?utf-8?B?MmNVY2hwOVVXRVFLYklRcjdWUGt3YWg5OWVScEkwSXBDazgraUdKSmU1OVJC?=
 =?utf-8?B?V1gzWHhnUzIzaVFpTUdEOEZMTW1tRE1qcWx3eWdHejMzRThvcnBoM3JvaTRh?=
 =?utf-8?B?djRxR2cwOGFEQmRoTEMyWExZWlM5QTJpSG1MczBOQjMzK1RQUkV2N1VCV2Mv?=
 =?utf-8?B?YkQ0ZE5iTWsyUVp3VGZrT1J3ZURIMUs0MTNLTERtaFVYeUQvcno2TVJTWDdP?=
 =?utf-8?B?QTNSWEd3MDZCTXNYbkVyUFZjd095OGUyL0pNaUhHMDJHNFo2NWJGQjhSLzlH?=
 =?utf-8?B?aGFPWTJrSCtJMVM1TjZlM1JwNXdLT1ZuNHErVWhUWUZmVmtpYlRCN1hvMXN1?=
 =?utf-8?B?bHc4WHhyVlU5STRsSkZ1Z2JaYnQ1cXJETDRmTmU1eHRFQXFBOTFDaVNVT2tC?=
 =?utf-8?Q?a/YZ/0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1421d8f-fdf5-46fb-790f-08db972772a7
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:19:48.8993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5zpggnDz1Da4uJLQCEA/YR88xctPG92G1+XEMRDU9BnCv11uxFXbjBhp+576kLzVRnUDvH5vQA4mOYEKREObdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6916
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-07_08,2023-08-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2308070086
X-Proofpoint-GUID: zbQtpHV74QPDK1jucMV64DsSU0CfWTDC
X-Proofpoint-ORIG-GUID: zbQtpHV74QPDK1jucMV64DsSU0CfWTDC
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/08/2023 08:51, Jing Zhang wrote:
> The jevent "Compat" is used for uncore PMU alias or metric definitions.
> 
> The same PMU driver has different PMU identifiers due to different
> hardware versions and types, but they may have some common PMU event.
> Since a Compat value can only match one identifier, when adding the
> same event alias to PMUs with different identifiers, each identifier
> needs to be defined once, which is not streamlined enough.
> 
> So let "Compat" supports matching multiple identifiers for uncore PMU
> alias. For example, the Compat value {43401;436*} can match the PMU
> identifier "43401", that is, CMN600_r0p0, and the PMU identifier with
> the prefix "436", that is, all CMN650, where "*" is a wildcard.
> Tokens in Unit field are delimited by ';' with no spaces.
> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>
> ---

Reviewed-by: John Garry <john.g.garry@oracle.com>