Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 13:21:29 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
cc:     Shuah Khan <skhan@linuxfoundation.org>,
        linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory"
 param from run_fill_buf()
In-Reply-To: <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
Message-ID: <89befd7d-f756-f462-3986-a63f4e3dba86@linux.intel.com>
References: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com> <20230717131507.32420-13-ilpo.jarvinen@linux.intel.com> <7bba4db8-eaac-238d-b764-89d0ae2a9bba@linuxfoundation.org> <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1195163407-1691403693=:9752"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1195163407-1691403693=:9752
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Tue, 25 Jul 2023, Reinette Chatre wrote:

> Hi Shuah,
> 
> On 7/25/2023 7:49 AM, Shuah Khan wrote:
> > WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> > #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276:
> > +        strcpy(benchmark_cmd[3], "0");
> > 
> > WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> > #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277:
> > +        strcpy(benchmark_cmd[4], "");
> > 
> > total: 0 errors, 2 warnings, 142 lines checked
> > 
> > I am applying the patch set to linux-kselftest next - please fix
> > the aboe and send a patch on top of linux-kselftest next
> 
> Is strscpy() available to userspace? I found lib/strscpy_kunit.c
> that makes me think this is currently only available to kernel code.

It's not available and I've done so little userspace programming in 
the recent years (and even less string manipulation in userspace C)
I've no idea what would be the best way to replace it.

However, I've a few patches which will cleanup the benchmark command 
handling that include removal of these strcpy()s. Those changes looked 
separate enough from the rest I can send it independent of that CAT 
rewrite which would have been the next entry in my pending resctrl 
selftest patches queue.


-- 
 i.

--8323329-1195163407-1691403693=:9752--