Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4108800-8a4d-910b-7b22-6b4a4f4f5302@xs4all.nl>
Date:   Mon, 7 Aug 2023 13:02:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] [media] dvb-frontends: add missing spaces before ','
Content-Language: en-US, nl
To:     sunran001@208suo.com, mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230720023552.1070-1-xujianghui@cdjrlc.com>
 <9bf6cfcbeb9a0854fdb2a29d74885725@208suo.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <9bf6cfcbeb9a0854fdb2a29d74885725@208suo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Ran Sun,

On 20/07/2023 04:37, sunran001@208suo.com wrote:
> Add missing spaces to clear checkpatch errors.
> 
> ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>

The patch in patchwork is corrupt:

https://patchwork.linuxtv.org/project/linux-media/patch/9bf6cfcbeb9a0854fdb2a29d74885725@208suo.com/

Probably line wrapping issues. Please check your mailer settings!

Regards,

	Hans

> ---
>  drivers/media/dvb-frontends/dib3000mc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/dib3000mc.h b/drivers/media/dvb-frontends/dib3000mc.h
> index 5ed3d9147f8b..b837e107881e 100644
> --- a/drivers/media/dvb-frontends/dib3000mc.h
> +++ b/drivers/media/dvb-frontends/dib3000mc.h
> @@ -73,7 +73,7 @@ struct i2c_adapter *dib3000mc_get_tuner_i2c_master(struct dvb_frontend *demod,
>  }
>  #endif // CONFIG_DVB_DIB3000MC
> 
> -extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index, int pid,int onoff);
> +extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index, int pid, int onoff);
>  extern int dib3000mc_pid_parse(struct dvb_frontend *fe, int onoff);
> 
>  extern void dib3000mc_set_config(struct dvb_frontend *, struct dib3000mc_config *);