Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f9ed06cb-2c9b-6b82-0bb4-2189a05218a1@collabora.com>
Date:   Mon, 7 Aug 2023 14:05:37 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow
Content-Language: en-US
To:     Hsin-Te Yuan <yuanhsinte@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Hsin-Te Yuan <yuanhsinte@google.com>
References: <20230807085811.1.I7d08b8323531c59c0ec247570b2d05a790bfd3d4@changeid>
From:   Eugen Hristev <eugen.hristev@collabora.com>
In-Reply-To: <20230807085811.1.I7d08b8323531c59c0ec247570b2d05a790bfd3d4@changeid>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Hsin-Te,

On 8/7/23 11:58, Hsin-Te Yuan wrote:
> The external output reset signal was originally disabled and sent from
> firmware. However, an unfixed bug in the firmware prevents the signal
> from being sent, causing the device to fail to boot. To fix this, enable
> external output reset signal to allow the device to reboot normally.
> 
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@google.com>
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 37a3e9de90ff7..5dc4214e1840b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -1147,6 +1147,10 @@ &uart0 {
>   	status = "okay";
>   };
>   
> +&watchdog {
> +	/delete-property/ mediatek,disable-extrst;
> +};
> +

Does this affect only the mt8195-cherry or all mt8195 boards ?

Judging by this commit , I think only mt8195-cherry, but your commit 
message somehow suggests otherwise.

Eugen

>   &xhci0 {
>   	status = "okay";
>