Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp2872888rwb; Mon, 7 Aug 2023 05:05:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnYPZqyfj1jsSdA69ma8+L6xKi0hV0VWD9zeTlidWNPZ+bc0xhQ9+MGgRv2fSxH0Fh7uln X-Received: by 2002:a17:903:41cd:b0:1b6:72af:623d with SMTP id u13-20020a17090341cd00b001b672af623dmr8241269ple.55.1691409922186; Mon, 07 Aug 2023 05:05:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691409922; cv=none; d=google.com; s=arc-20160816; b=OrlMZxp75cmuxe4EZLIqYPJAivCChmnMib5VqtEtACTIp5SXwJ6HjWcIQ9YBgU93XG 7X+ygYdhTnDz80X+fvpHOA4gbAa3e6QfCMQVbBNuobClUyy7C5vJKotQ9/UmwQhTNa0p Nyr3/1wIVXSu/05gVgPBzqYu/Pka63B4y/31l0sLqWwjp8xYypnYuAsIOd8l99Jg1F9I qQeDr/M7rk6+TSSk8D6iWp9FtfKZIHmeJL+JNQyYpId6Qqzu8FkE5MXgrjkGj6/mrY0I hzis6RGeKLRSs2DXMia1B+8jT71d31RpOG2lh67CUxlkQeG6wiQJTra1rq2zEMM55iEp 7Nng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=+J8+GbbnQr//FocMw8B3b+7OOVPT1IHpOJbncT0Qlaw=; fh=i+IQzfuYL8rw1t1zUu6oUZBtyiPXH0V/ixrlfJyK3M0=; b=NzR6A2mpqx31MAVNQjop8cxlgq/MH8+JGF28+pjMmUAW4exLY60eZ3AAEbECq9an3w xHba6VB1RimIysNK57gCrPmo8BUkqmNDTVRvDvSMvOgMo4wJGeZVGROVmyzJX0IUZWC5 kQ7LdL/PHr7cIp26WQnXduUfBnkMhUvMNUKy3YPlwKZD2eaFhw2z5Ds2MibQLaeyLw1+ 0CWnfna03xOCLjq0KCDsd/4ocVo2BWsW/OY/MMgZHgkMBhmRVhXZydiwWnKQTl58AX6i +LDaiVR/eOlZYI4h49Bjpyhpy3gZ7bNbzsb2U9FHV/PR7tHMeEGdfbCoQt0kGTjcKs/T 4jWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VGjJjiA/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a170903228d00b001bbabd5b14esi5803053plh.608.2023.08.07.05.05.04; Mon, 07 Aug 2023 05:05:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VGjJjiA/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232867AbjHGLeM (ORCPT + 99 others); Mon, 7 Aug 2023 07:34:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233286AbjHGLdc (ORCPT ); Mon, 7 Aug 2023 07:33:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EFE4EF4; Mon, 7 Aug 2023 04:31:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED7146187F; Mon, 7 Aug 2023 11:20:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50EBCC433CA; Mon, 7 Aug 2023 11:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691407207; bh=lfov+GI9PtgjRx7EN6YfaLKl9aVqTtIrT6Szi7Q5Aw0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VGjJjiA/AR6RZlEx3M6eiKSYq97WMJhhiBtOLOFsPk7larBUKSpY6orDIQ37W40Eg CkqBNC7jUKQk0V7TvLsE15J9VZMBiVdm2pb4oVHqqPLXKq0rQ47jG9DaKHQV6dyqG/ /GElL6HneXvTVdRJvuU42r2DcJFAZGFYI3ojxZHDPpka14OaeWtZCw0XsncjjBmT+v nKwIMBRphNY4JzOev79uLBmc0lUCwdAAKQn7j++7OPIqCq1rD1K4CqPDdZdNCV+2Im GCDuyHXYd66NvsEt1UDm+2LKH/KEV7mefNkOlXl1Ijm14BPzcDnTFoEXJCfqcQQuoQ IK0t/UdJU9E/w== Date: Mon, 7 Aug 2023 13:19:54 +0200 (CEST) From: Jiri Kosina To: Andy Shevchenko cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings In-Reply-To: Message-ID: References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Aug 2023, Andy Shevchenko wrote: > On Thu, Jul 27, 2023 at 09:43:29PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 03, 2023 at 09:52:10PM +0300, Andy Shevchenko wrote: > > > After I updated GPIO library for the case Benjamin has with CP2112, > > > I have a brief look into the CP2112 driver itself. > > > > > > From GPIO perspective it has two main (maitenance) issues: > > > - usage of ->to_irq() with IRQ chip present; > > > - having IRQ chip not immutable. > > > > > > Besides that there are plenty small cleanups here and there. > > > Hence this series. > > > > Any comments on this? > > Gentle ping^2 for this... > > Anything should I do to improve it or is it okay to go as is? I have been off pretty much the whole July. I am now back and slowly making my way through everything that accumulated, I will eventually get to this. Thanks for the patience, -- Jiri Kosina SUSE Labs