Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <135d7bc4-c6a0-30fd-428a-20bd886efa58@collabora.com>
Date:   Mon, 7 Aug 2023 13:22:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/5] docs: uapi: media: Properly locate NV12MT diagram
To:     Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     kernel@collabora.com, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230804192737.19016-1-nicolas.dufresne@collabora.com>
 <20230804192737.19016-2-nicolas.dufresne@collabora.com>
Content-Language: en-US
From:   Andrzej Pietrasiewicz <andrzej.p@collabora.com>
In-Reply-To: <20230804192737.19016-2-nicolas.dufresne@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

W dniu 4.08.2023 o 21:27, Nicolas Dufresne pisze:
> The diagram have been pushed back at the end of a list of unrelated
> pixels formats. Move it back next its related pixel format.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> ---
>   .../media/v4l/pixfmt-yuv-planar.rst           | 32 +++++++++----------
>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> index 1840224faa41..fb826923ff1d 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> @@ -322,6 +322,22 @@ If the vertical resolution is an odd number of tiles, the last row of
>   tiles is stored in linear order. The layouts of the luma and chroma
>   planes are identical.
>   
> +.. _nv12mt:
> +
> +.. kernel-figure:: nv12mt.svg
> +    :alt:    nv12mt.svg
> +    :align:  center
> +
> +    V4L2_PIX_FMT_NV12MT macroblock Z shape memory layout
> +
> +.. _nv12mt_ex:
> +
> +.. kernel-figure:: nv12mt_example.svg
> +    :alt:    nv12mt_example.svg
> +    :align:  center
> +
> +    Example V4L2_PIX_FMT_NV12MT memory layout of tiles
> +
>   ``V4L2_PIX_FMT_NV12_4L4`` stores pixels in 4x4 tiles, and stores
>   tiles linearly in memory. The line stride and image height must be
>   aligned to a multiple of 4. The layouts of the luma and chroma planes are
> @@ -369,22 +385,6 @@ image height must be aligned to a multiple of 32. The number of luma and chroma
>   tiles are identical, even though the tile size differ. The image is formed of
>   two non-contiguous planes.
>   
> -.. _nv12mt:
> -
> -.. kernel-figure:: nv12mt.svg
> -    :alt:    nv12mt.svg
> -    :align:  center
> -
> -    V4L2_PIX_FMT_NV12MT macroblock Z shape memory layout
> -
> -.. _nv12mt_ex:
> -
> -.. kernel-figure:: nv12mt_example.svg
> -    :alt:    nv12mt_example.svg
> -    :align:  center
> -
> -    Example V4L2_PIX_FMT_NV12MT memory layout of tiles
> -
>   .. _V4L2-PIX-FMT-NV15-4L4:
>   
>   Tiled NV15