Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807112705.12862-1-aboutphysycs@gmail.com>
In-Reply-To: <20230807112705.12862-1-aboutphysycs@gmail.com>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Mon, 7 Aug 2023 14:58:54 +0300
Message-ID: <CAH3L5QrySJPGT9ZYkV1nC2x+gPKMj7JEbZoCLjzkQjEd2oRjcQ@mail.gmail.com>
Subject: Re: [PATCH] reset: uniphier-glue: remove unneeded call to platform_set_drvdata()
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        mhiramat@kernel.org, hayashi.kunihiko@socionext.com,
        p.zabel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 2:27=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail.c=
om> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Als=
o,
> the private data is defined in this driver, so there is no risk of it bei=
ng
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/reset/reset-uniphier-glue.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-uniphier-glue.c b/drivers/reset/reset-un=
iphier-glue.c
> index 15abac9fc72c..df41b75786ad 100644
> --- a/drivers/reset/reset-uniphier-glue.c
> +++ b/drivers/reset/reset-uniphier-glue.c
> @@ -99,8 +99,6 @@ static int uniphier_glue_reset_probe(struct platform_de=
vice *pdev)
>         priv->rdata.rcdev.of_node =3D dev->of_node;
>         priv->rdata.active_low =3D true;
>
> -       platform_set_drvdata(pdev, priv);
> -
>         return devm_reset_controller_register(dev, &priv->rdata.rcdev);
>  }
>
> --
> 2.34.1
>