Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp2918472rwb; Mon, 7 Aug 2023 05:45:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEm+Ul3o8I4A2NKWfkOcSi59ewp8UZOx0bO+80JaqGUllEf5wRh/tewr3pEmPaSd+ykw5hU X-Received: by 2002:aa7:c651:0:b0:522:3ea4:81a9 with SMTP id z17-20020aa7c651000000b005223ea481a9mr7587109edr.34.1691412300291; Mon, 07 Aug 2023 05:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691412300; cv=none; d=google.com; s=arc-20160816; b=G+uZLHvriULxXhKckyMQiJtgiUWvFCWrwv7ysqdWGEuiMhe2d/z9cQU+5cbhoVvoRd Wt2mzQ7udUcvrz/l+9S5XBQoziR+glZx7udUEvrDLz2iUJhihwhNfKAZJjahKr7CywTk vTn5GsRMI4+A4089y9VjpHnaLonBrDubPncpV3woN+OF7lF1sATSgMsRk1jln28GzdXk e8cNg1f2ardJT665mzLTa+6GKhEn332yHqWss4KXRVEGTJEcENtACgiw/VlFz2tO9L+1 5FE2+qefXuHrfGPf69N6a4ljIJtg1z2gnQKksava8kJixsXNQ5xav8//2ZNBz36g1nxR kZ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=TcaKDL5HswRCdoktEiAPamDPst8IQ4b9BuRmTrbnKT0=; fh=KcDyYO7WSz7frtmcSRLriyeGC1Otz+FDYU0OVdUQ24w=; b=Whh0dn0yuDzJbaaGFpBQ4F2fKiTtlCVyOiAG3V9bnqiXusgxwIYwNYYhRH7zrbri5/ Gm5GDQbzhl1TRMUwRW2pWdrCB2eKdEUKsRsnXYLuuIwsTg3+Gr1rqD99OgjuZR0GW3yo tPHZjWvQyeaWGRH5IhUXaL50m0aPMBDpElMdbHEZH2NiaVjdvD+J31QarW7StkV7LHPB EQvT1zy3xX7L2j048W3pXjwqnTn57GsnUN/H9IqGIKVQZMzjcutFXZd4ln9lJihNALSP 0US0K1KIDPICMt4WnNeNmArSlqWTHBvisM82zm91cwMjvr+eTKQkVf5m8DUBnGTgMNys //uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay25-20020a056402203900b00523287903d4si3461993edb.380.2023.08.07.05.44.34; Mon, 07 Aug 2023 05:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231760AbjHGLwx (ORCPT + 99 others); Mon, 7 Aug 2023 07:52:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjHGLwv (ORCPT ); Mon, 7 Aug 2023 07:52:51 -0400 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B77969E; Mon, 7 Aug 2023 04:52:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VpGjZjh_1691409162; Received: from 30.221.158.57(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VpGjZjh_1691409162) by smtp.aliyun-inc.com; Mon, 07 Aug 2023 19:52:44 +0800 Message-ID: Date: Mon, 7 Aug 2023 19:52:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 3/7] perf jevents: Support more event fields To: John Garry , Ian Rogers Cc: Will Deacon , James Clark , Arnaldo Carvalho de Melo , Mark Rutland , Mike Leach , Leo Yan , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue References: <1691394685-61240-1-git-send-email-renyu.zj@linux.alibaba.com> <1691394685-61240-4-git-send-email-renyu.zj@linux.alibaba.com> <50a8778a-ebe4-5b3b-9367-c8547d6d991d@oracle.com> From: Jing Zhang In-Reply-To: <50a8778a-ebe4-5b3b-9367-c8547d6d991d@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/7 下午5:24, John Garry 写道: > On 07/08/2023 08:51, Jing Zhang wrote: >> The usual event descriptions are "event=xxx" or "config=xxx", while the >> event descriptions of CMN are "type=xxx, eventid=xxx" or more complex. >> >> $cat /sys/bus/event_source/devices/arm_cmn_0/events/hnf_cache_fill >> type=0x5,eventid=0x3 >> >> When adding aliases for events described as "event=xxx" or "config=xxx", >> EventCode or ConfigCode can be used in the JSON files to describe the >> events. But "eventid=xxx, type=xxx" cannot be supported at present. >> >> If EventCode and ConfigCode is not added in the alias JSON file, the >> event description will add "event=0" by default. So, even if the event >> field is added to supplement "eventid=xxx" and "type=xxx", the final >> parsing result will be "event=0, eventid=xxx, type=xxx". >> >> Therefore, when EventCode and ConfigCode are missing in JSON, "event=0" is >> no longer added by default. EventIdCode and Type are added to the event >> field, and ConfigCode is moved into the event_field array which can also >> guarantee its original function. >> >> Signed-off-by: Jing Zhang > > I'll let Ian check this change as he is more familiar with this code. > Ok, thanks!