Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807113545.14743-1-aboutphysycs@gmail.com>
In-Reply-To: <20230807113545.14743-1-aboutphysycs@gmail.com>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Mon, 7 Aug 2023 15:00:30 +0300
Message-ID: <CAH3L5QpJztEie-OO8QbnBOMpZ3RtLuepMCyrj1bq7pPCZSNV3Q@mail.gmail.com>
Subject: Re: [PATCH] reset: zynq: remove unneeded call to platfrom_set_drvdata()
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        michal.simek@amd.com, p.zabel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 2:35=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail.c=
om> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Als=
o,
> the private data is defined in this driver, so there is no risk of it bei=
ng
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/reset/reset-zynq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/reset/reset-zynq.c b/drivers/reset/reset-zynq.c
> index 706bbbbb4ec7..688b512882ec 100644
> --- a/drivers/reset/reset-zynq.c
> +++ b/drivers/reset/reset-zynq.c
> @@ -94,7 +94,6 @@ static int zynq_reset_probe(struct platform_device *pde=
v)
>         priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
>         if (!priv)
>                 return -ENOMEM;
> -       platform_set_drvdata(pdev, priv);
>
>         priv->slcr =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
>                                                      "syscon");
> --
> 2.34.1
>