Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 14:10:57 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        Randy Dunlap <rdunlap@infradead.org>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Daniel Golle <daniel@makrotopia.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH v8 4/8] nvmem: core: Track the registered devices
Message-ID: <20230807141057.64976ee1@xps-13>
In-Reply-To: <2023080732-gulp-pancake-93a5@gregkh>
References: <20230807082419.38780-1-miquel.raynal@bootlin.com>
        <20230807082419.38780-5-miquel.raynal@bootlin.com>
        <2023080732-gulp-pancake-93a5@gregkh>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Greg,

gregkh@linuxfoundation.org wrote on Mon, 7 Aug 2023 11:02:35 +0200:

> On Mon, Aug 07, 2023 at 10:24:15AM +0200, Miquel Raynal wrote:
> > Create a list with all the NVMEM devices registered in the
> > subsystem. This way we can iterate through them when needed (unused for
> > now).
> >=20
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  drivers/nvmem/core.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >=20
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index 257328887263..4e81e0aaf433 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -23,6 +23,7 @@
> >  struct nvmem_device {
> >  	struct module		*owner;
> >  	struct device		dev;
> > +	struct list_head	node;
> >  	int			stride;
> >  	int			word_size;
> >  	int			id;
> > @@ -76,6 +77,9 @@ static LIST_HEAD(nvmem_cell_tables);
> >  static DEFINE_MUTEX(nvmem_lookup_mutex);
> >  static LIST_HEAD(nvmem_lookup_list);
> > =20
> > +static DEFINE_MUTEX(nvmem_devices_mutex);
> > +static LIST_HEAD(nvmem_devices_list); =20
>=20
> But this list should already be in the driver core, why create
> yet-another-list-and-lock?

I did not think about using it. I believe you mean using
bus_for_each_dev() here? Could definitely make the trick; I'll try.

>=20
> Why is "when needed" not sufficient to use the list already present?
>=20
> And now note, you have the same structure on 2 different lists, watch
> out for device lifetime rules :(
>=20
> thanks,
>=20
> greg k-h


Thanks,
Miqu=C3=A8l