Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 14:27:33 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        nick.hawkins@hpe.com, verdun@hpe.com, alex@shruggie.ro
Subject: Re: [PATCH] spi: gxp: removed unneeded call to platform_set_drvdata()
Message-ID: <c867e685-7665-420b-9478-bce6eb067463@sirena.org.uk>
References: <20230807130217.17853-1-aboutphysycs@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zAdnmFfTpGPFqY1x"
Content-Disposition: inline
In-Reply-To: <20230807130217.17853-1-aboutphysycs@gmail.com>
Precedence: bulk


--zAdnmFfTpGPFqY1x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 07, 2023 at 04:02:17PM +0300, Andrei Coardos wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

That isn't enough of a check here - people can still reference the
driver data without going through the accessor function.

--zAdnmFfTpGPFqY1x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTQ8UUACgkQJNaLcl1U
h9CYIAf/ROUAMJppuOVv7Ed0Jy9dMhO/EAh/6Zcy7y1tcWtyBsxYwiJc4gbub7lN
mr40zoxh993xeWFpyFbB7J+pQnPV6G+be9COxUK6RsIqVm2e0ybLC5lNv/o1pefh
3+otfuxQs0UxN6JPlRpTqNOfZW39sgKhLKxZduInP8Rwad/NszlPbTxvtQZjk4BL
tyt57gqHOHHn/dfgMB1kOnPS3LZ8H+oJoGLBulgoSa1RcCj1FMrRk4zqCQi/Sd+x
zYYNTUWR0Fcco/eqDIDjfPB3C/GGXQPL2cigV+tKcYwFznUsRzqnh48esqgxn5Gv
qV7kKyj5w54yGuz7mH6Rp+k1o9JJNg==
=esZH
-----END PGP SIGNATURE-----

--zAdnmFfTpGPFqY1x--