Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 16:33:40 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Michael Walle <michael@walle.cc>
Cc:     Michael Walle <mwalle@kernel.org>,
        Tudor Ambarus <tudor.ambarus@linaro.org>,
        Pratyush Yadav <pratyush@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 06/41] mtd: spi-nor: default page_size to 256 bytes
Message-ID: <20230807163340.1ebe1e15@xps-13>
In-Reply-To: <cebd793208c9956e0c7be1b528e16627@walle.cc>
References: <20230807-mtd-flash-info-db-rework-v1-0-3d3d5bef4ba4@kernel.org>
        <20230807-mtd-flash-info-db-rework-v1-6-3d3d5bef4ba4@kernel.org>
        <20230807154754.70e994fa@xps-13>
        <cebd793208c9956e0c7be1b528e16627@walle.cc>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Michael,

michael@walle.cc wrote on Mon, 07 Aug 2023 16:29:38 +0200:

> Hi Miquel,
>=20
> >> +	params->page_size =3D info->page_size ?: SPI_NOR_DEFAULT_PAGE_SIZE; =
=20
> >=20
> > Would you mind clarifying this? It does not look right, while
> > perhaps it is. But TBH, I have no idea what params->page_size will be
> > after this assignment. =20
>=20
> It's info->page_size, it's a shortcut [1].

Elvis operator :')

> I'm not the first one using it (in fact I was explicitly asked to use it,
> e.g. in gpio subsys):
>=20
> $ grep -r "?:" **/*.c |wc -l
> 1268

Okay then... I didn't know this was encouraged.

> -michael
>=20
> [1] https://en.wikipedia.org/wiki/Elvis_operator

Thanks,
Miqu=C3=A8l