Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cef38375a5259e7df0111821b112341ed670e682.camel@gmail.com>
Subject: Re: [PATCH v4 1/3] iio: Add IIO_DELTA_ANGL channel type
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Ramona Bolboaca <ramona.bolboaca@analog.com>, jic23@kernel.org,
        nuno.sa@analog.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 07 Aug 2023 16:26:17 +0200
In-Reply-To: <20230807111227.374371-2-ramona.bolboaca@analog.com>
References: <20230807111227.374371-1-ramona.bolboaca@analog.com>
         <20230807111227.374371-2-ramona.bolboaca@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-08-07 at 14:12 +0300, Ramona Bolboaca wrote:
> The delta angle is defined as a piece-wise integration of angular
> velocity data. The delta angle represents the amount of
> angular displacement between two consecutive measurements and it
> is measured in radians.
>=20
> In order to track the total angular displacement during a desired
> period of time, simply sum-up the delta angle samples acquired
> during that time.
>=20
> IIO currently does not offer a suitable channel type for this
> type of measurements hence this patch adds it.
>=20
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
> ---
> =C2=A0Documentation/ABI/testing/sysfs-bus-iio | 14 ++++++++++++++
> =C2=A0drivers/iio/industrialio-core.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 |=C2=A0 1 +
> =C2=A0include/uapi/linux/iio/types.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 |=C2=A0 1 +
> =C2=A0tools/iio/iio_event_monitor.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 ++
> =C2=A04 files changed, 18 insertions(+)
>=20
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio
> b/Documentation/ABI/testing/sysfs-bus-iio
> index a2854dc9a839..32675fa7dc6f 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -279,6 +279,20 @@ Description:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0but should match other such assignments on device).
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0Units after application of scale and offset are m/s=
^2.
> =C2=A0
> +What:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/sys/bu=
s/iio/devices/iio:deviceX/in_deltaangl_x_raw
> +What:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/sys/bu=
s/iio/devices/iio:deviceX/in_deltaangl_y_raw
> +What:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/sys/bu=
s/iio/devices/iio:deviceX/in_deltaangl_z_raw

I wonder if we also need to add these to the scan element specific bits? Fr=
om a
quick look, it seems not all supported attributes are in there so I'm not s=
ure
what's the policy in here :)


- Nuno S=C3=A1