Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liu, Yi L" <yi.l.liu@intel.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: RE: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Topic: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Index: AQHZvh/uqwr3PK6FO0KhG3jtetteiK/WrrGAgAhNwpA=
Date:   Mon, 7 Aug 2023 15:08:29 +0000
Message-ID: <DS0PR11MB7529F4D4DABBE29E9B7BF5C9C30CA@DS0PR11MB7529.namprd11.prod.outlook.com>
References: <20230724111335.107427-1-yi.l.liu@intel.com>
 <20230724111335.107427-10-yi.l.liu@intel.com>
 <BN9PR11MB527690EBAA872A16AE8926F88C0BA@BN9PR11MB5276.namprd11.prod.outlook.com>
In-Reply-To: <BN9PR11MB527690EBAA872A16AE8926F88C0BA@BN9PR11MB5276.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mtlzMzZkiEd8shFKPjZOQPlgF5EXznScqm6RMfIsrknOHAO+fI/Movck2Hy+?=
 =?us-ascii?Q?GwClwNOnHB+x2UhfeIXFler6lRA9bXy8BPrD81Rl2oSYvbpvG6AvUAOvw8zX?=
 =?us-ascii?Q?zo4m+12/mbN1HSTrHcWpp5g2Uf4iK0MdehtuWNFoc9Kc0LV2E7ufLs8SsccY?=
 =?us-ascii?Q?RrIng1epjUK3KjzhbhnqyJBV9icX06p1VI2I12eASDIm8dWgWZKBCSYSR5IX?=
 =?us-ascii?Q?WsckPwHnDoRrIjHK0joRDgAxZkdhXrv/omsjrGmFxXn8elACOZiDvk0HpxYj?=
 =?us-ascii?Q?wK026B8ErXZt6E7yGrl2zPDQ81776QnLMnn6xvN4GY3S6PczgwtLMcrPXvxK?=
 =?us-ascii?Q?Lg6gvgsqcW8yHzNkUZShn6CB/13WfiG9k5Hba/CFojAT2A+PA/s+N8vdBRl0?=
 =?us-ascii?Q?nBNFFAdGm2tHUlthppViy4wNTHXiICAIHrcJzy3Yopfl2Jlb+HDAOMZqwIMp?=
 =?us-ascii?Q?3TqfcFXAWNVF8VtkTOx5xOLKwk3E7meHa8QxqdEaz8yjv/3kEpa5YYnx78Fo?=
 =?us-ascii?Q?m9qd7jfYAC1s77eveH+TviT5lkyHIc/4mYaHtd7WXo/T+GP1A02SjkaUXeHW?=
 =?us-ascii?Q?AgtTnXArVE1CERNTxBO/Xz75UFpALK5RvX1MCQ5iTWoqmaBxW/V+vjxKCcX8?=
 =?us-ascii?Q?JbEbya9OA5LwNsEAIphYl2mX/p6fEMfmbI3DE/VH6yUPF+HKSnrML6ldHqgJ?=
 =?us-ascii?Q?OisHRQEDKOl2w9hsgl9nlzsEJUmKvC0NtFghTBSZLvr810HO7TUXblVZKG8D?=
 =?us-ascii?Q?UwiGmF3pPK5JLKJXCW0JBuizhf+c1o4cXCRqe3dBm2N5Va+jzdt6vHATk3mC?=
 =?us-ascii?Q?0U6AEVogWF1ewqDOxyIRRG3FW7tkRqGiJAyXQMmC3BLQASTp/d8cwwe2qHNn?=
 =?us-ascii?Q?M6DLCCaK5N51j3V9CH6EkH42DN0/Fngi7YrzeXrTdR8icKP3ZZMQr+qwCXXI?=
 =?us-ascii?Q?e/Q5M6V0jkh9QHpGJjyu6saQHEVJzAzIf5V0j3uveNpMJUMYHMZ3TeMd7bpn?=
 =?us-ascii?Q?G9uPSO00zzH9SZTty+UfKDsmxofWi3dXH9fbPoi7x8qe593S2HrQ9eVqreea?=
 =?us-ascii?Q?VSKG0c3ZxcAZ65ndgwI9QI484Lv3gqBg4v6d7N+uJtyVllVjJbfwzMYTeWO2?=
 =?us-ascii?Q?UkueR7cVydv0RR80ekpJcPIX0/Rc/Jq5FxUspdAknaxL5F922gLVhqi/C1LT?=
 =?us-ascii?Q?09sZUX8NSJH+dtiTpzBQpBBhVqbU1B80wrZuDPRmC+Yfm6VBpCvgSRN54tJb?=
 =?us-ascii?Q?+5T5S/3HeN2RJIFQoy6PwM4Wlbfy5DRLXFbowB1BvVB+nxAR1BT6IHgijeTE?=
 =?us-ascii?Q?tuvglSjLkR0LQHsau4RATCvSeDM5gic+YLJqWpk5PdtG5RPSw0ZgGipRFP0Z?=
 =?us-ascii?Q?De2WMLb0jyprBi9eM+U6LRwbvISgHmNb/+1yC1tAqaqfeI7Pt+YyjMnLst4m?=
 =?us-ascii?Q?+pyqdWxx6pDkOye+/MAz5z0jjq1ZQ1j4kL8QyEm8p3UkltRu5eR1eQ/ae98T?=
 =?us-ascii?Q?zUyyUa0cpZH2FsqIbEx7+rjoTlu3RZCUoAhwWY6ty78KS49TP3DEJciwTg?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2588996b-511f-4f28-457d-08db975828a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 15:08:29.7645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zq7t591YG6hlX8XfMCuHuGhppKSBltg1H9qbrv1wNO4ppzNwEDUaQ5YTbvoNkLXgfpJc/noE/aI2ofjHLLPkVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7421
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Tian, Kevin <kevin.tian@intel.com>
> Sent: Wednesday, August 2, 2023 3:47 PM
>
> Subject: RE: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested doma=
in
>=20
> > From: Liu, Yi L <yi.l.liu@intel.com>
> > Sent: Monday, July 24, 2023 7:14 PM
> >
> > +static int intel_nested_cache_invalidate_user(struct iommu_domain
> > *domain,
> > +					      void *user_data)
> > +{
> > +	struct iommu_hwpt_vtd_s1_invalidate_desc *req =3D user_data;
> > +	struct iommu_hwpt_vtd_s1_invalidate *inv_info =3D user_data;
> > +	struct dmar_domain *dmar_domain =3D to_dmar_domain(domain);
> > +	unsigned int entry_size =3D inv_info->entry_size;
> > +	u64 uptr =3D inv_info->inv_data_uptr;
> > +	u64 nr_uptr =3D inv_info->entry_nr_uptr;
> > +	struct device_domain_info *info;
> > +	u32 entry_nr, index;
> > +	unsigned long flags;
> > +	int ret =3D 0;
> > +
> > +	if (get_user(entry_nr, (uint32_t __user *)u64_to_user_ptr(nr_uptr)))
> > +		return -EFAULT;
> > +
> > +	for (index =3D 0; index < entry_nr; index++) {
> > +		ret =3D copy_struct_from_user(req, sizeof(*req),
> > +					    u64_to_user_ptr(uptr + index *
> > entry_size),
> > +					    entry_size);
>=20
> If continuing this direction then the driver should also check minsz etc.
> for struct iommu_hwpt_vtd_s1_invalidate and iommu_hwpt_vtd_s1_invalidate_=
desc
> since they are uAPI and subject to change.

Then needs to define size in the uapi data structure, and copy size first a=
nd
check minsz before going forward. How about the structures for hwpt alloc
like struct iommu_hwpt_vtd_s1? Should check minsz for them as well?
=20
Regards,
Yi Liu